[src] Augment the Native attribute to support custom conversion functions. Fixes #12111. #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Fixes xamarin#12111. Augment the Native attribute for enums to support custom conversion functions between native values and managed values for enums. This makes it possible to have different values in managed code for an enum compared to native code. This is necessary to support different native enum values based on the architecture, because in a few cases Apple has different enum values between x86_64 and ARM64. Enum values are constants in managed code, and without this support it would be impossible to translate these correctly to native code. The updated Native attribute supports two new fields: ConvertToNative and ConvertToManaged, which are managed functions of a specific signature that the generator will emit calls to whenever needed to do the appropriate conversion. Fixes xamarin#12111.
rolfbjarne
added
not-notes-worthy
spouliot
approved these changes
Aug 19, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 142 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 144 tests passed 🎉Pipeline on Agent XAMBOT-1104.BigSur' |
rolfbjarne
deleted the
issue-12111-convert-enums-to-native-and-back-again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the Native attribute for enums to support custom conversion functions between
native values and managed values for enums. This makes it possible to have different
values in managed code for an enum compared to native code.
This is necessary to support different native enum values based on the architecture,
because in a few cases Apple has different enum values between x86_64 and ARM64.
Enum values are constants in managed code, and without this support it would be impossible
to translate these correctly to native code.
The updated Native attribute supports two new fields: ConvertToNative and ConvertToManaged,
which are managed functions of a specific signature that the generator will emit
calls to whenever needed to do the appropriate conversion.
Fixes #12111.