Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maccore. #12675

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Bump maccore. #12675

merged 1 commit into from
Sep 10, 2021

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Sep 9, 2021

New commits in xamarin/maccore:

Diff: https://github.com/xamarin/maccore/compare/3e591cbcb15081d34a9512ca39d9df55c331bdbd..efad4f0baec567c7937ce0a87b2fc94ee0094a2b

New commits in xamarin/maccore:

* xamarin/maccore@efad4f0bae [Xamarin.Hosting] Fix a few compiler warnings. (#2512)
* xamarin/maccore@55087e093a [Xamarin.Hosting] Fix detecting app exit on device. (#2511)
* xamarin/maccore@ffefee386c [Xamarin.Hosting] Add support for launching with debugserver on iOS/tvOS 14+. (#2510)
* xamarin/maccore@e203814d08 [tests] Fix .ipa path for iOSCoolApp now that it's a fat app. (#2509)
* xamarin/maccore@c2531ff702 Update the provisionator script. (#2505)
* xamarin/maccore@2bfa5fa12b [submission] Add a fat Mac Catalyst test app. (#2508)

Diff: https://github.com/xamarin/maccore/compare/3e591cbcb15081d34a9512ca39d9df55c331bdbd..efad4f0baec567c7937ce0a87b2fc94ee0094a2b
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 9, 2021
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the bump script needs an update :)

using (xamarin/maccore#2512) instead of (#2512) seems to works fine (as expected) but it does repeat the text (so a larger change might be better)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 97 tests passed.

Failed tests

  • link sdk/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • link sdk/tvOS - simulator/Debug: Failed
  • link sdk/tvOS - simulator/Release: Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 30b3e79 into 07f83a8

@rolfbjarne
Copy link
Member Author

Seems the bump script needs an update :)

Script has been fixed!

It now removes (#1234) at the end of the commit message, and then transforms any other #1234 to xamarin/maccore#1234 (because those are likely different, a part of "Fixes #....").

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/1605).

@rolfbjarne rolfbjarne merged commit 855de96 into main Sep 10, 2021
@rolfbjarne rolfbjarne deleted the bump-maccore-2021-09-09 branch September 10, 2021 12:31
premun added a commit to premun/xharness that referenced this pull request Sep 15, 2021
premun added a commit to dotnet/xharness that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants