[CoreMedia] Add support for xcode13 #12770

mandel-macaque · 2021-09-17T17:44:39Z

No description provided.

vs-mobiletools-engineering-service2 · 2021-09-17T21:57:22Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

11 tests failed, 91 tests passed.

Failed tests

introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 44 Passed: 40 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Modern/Debug: Failed (Test run failed.
Tests run: 37 Passed: 33 Inconclusive: 0 Failed: 3 Ignored: 1)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
introspection/tvOS - simulator/Debug (tvOS 11.4): Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Failed
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 2657 Passed: 2490 Inconclusive: 35 Failed: 2 Ignored: 165)
dont link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1096.BigSur'
Merge a9eda1b into d94a0f5

src/CoreMedia/CMSync.cs

tj-devel709 · 2021-09-20T14:57:20Z

src/CoreMedia/CMSync.cs

@@ -411,20 +468,30 @@ public CMTimebaseError SetTimerToFireImmediately (NSTimer timer)

 #if !NET
 		[TV (13,0), Mac (10,15), iOS (13,0)]


Should this line be removed as well?

What do you want me to remove? The deprecation is needed for classic. The unsupported is needed as well, else it will use the default, since the minimum versions are 10 for iOS/tvOS, 10.4 for mac OS x and no watch. Without the Unsupported it will be assumed that they are present in those platforms. If anything we could remove the os version number.

tj-devel709 · 2021-09-20T15:03:03Z

src/CoreMedia/CMSync.cs

+		[UnsupportedOSPlatform ("ios8.0")]
+		[UnsupportedOSPlatform ("tvos9.0")]
+		[UnsupportedOSPlatform ("maccatalyst")]
+		[UnsupportedOSPlatform ("macos10.10")]
 #endif
 		[DllImport(Constants.CoreMediaLibrary)]
 		extern static CMTimebaseError CMTimebaseSetMasterTimebase (/* CMTimebaseRef* */ IntPtr timebase, /* CMTimebaseRef* */ IntPtr newMasterTimebase);

 #if !NET
 		[TV (13,0), Mac (10,15), iOS (13,0)]


Maybe same with this one

tj-devel709 · 2021-09-20T15:03:20Z

src/CoreMedia/CMSync.cs

@@ -436,20 +503,30 @@ public CMTimebaseError SetMasterTimebase (CMTimebase newMasterTimebase)

 #if !NET
 		[TV (13,0), Mac (10,15), iOS (13,0)]


tj-devel709 · 2021-09-20T15:03:27Z

src/CoreMedia/CMSync.cs

+		[UnsupportedOSPlatform ("ios8.0")]
+		[UnsupportedOSPlatform ("tvos9.0")]
+		[UnsupportedOSPlatform ("maccatalyst")]
+		[UnsupportedOSPlatform ("macos10.10")]
 #endif
 		[DllImport(Constants.CoreMediaLibrary)]
 		extern static CMTimebaseError CMTimebaseSetMasterClock (/* CMTimebaseRef* */ IntPtr timebase, /* CMClockRef* */ IntPtr newMasterClock);

 #if !NET
 		[TV (13,0), Mac (10,15), iOS (13,0)]


src/CoreMedia/CMSync.cs

Co-authored-by: TJ Lambert <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

…amarin-macios into coremedia-xcode13-beta5

vs-mobiletools-engineering-service2 · 2021-09-20T20:44:43Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

9 tests failed, 93 tests passed.

Failed tests

introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 44 Passed: 40 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Modern/Debug: Failed (Test run failed.
Tests run: 37 Passed: 33 Inconclusive: 0 Failed: 3 Ignored: 1)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
introspection/tvOS - simulator/Debug (tvOS 11.4): Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Failed

Pipeline on Agent XAMBOT-1099.BigSur'
Merge 5040693 into a6eb528

vs-mobiletools-engineering-service2 · 2021-09-24T01:10:32Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 44 Passed: 41 Inconclusive: 0 Failed: 1 Ignored: 2)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge a952f2a into 8ba7ff3

rolfbjarne · 2021-09-20T06:57:08Z

src/CoreMedia/CMSync.cs

+			if (error != CMTimebaseError.None)
+				throw new ArgumentException (error.ToString ());
+
+			CFObject.CFRetain (Handle);


This isn't necessary, the handle parameter is marked as CM_RETURNS_RETAINED_PARAMETER in the header.

src/CoreMedia/CMSync.cs

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

vs-mobiletools-engineering-service2 · 2021-09-24T22:06:58Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

link sdk/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge d43c6db into 9a299ae

mandel-macaque · 2021-09-24T22:20:03Z

/sudo backport xcode13-ios

vs-mobiletools-engineering-service2 · 2021-09-24T22:20:34Z

Backport Job to branch xcode13-ios Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-09-24T22:21:52Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5250820 for more details.

mandel-macaque added 6 commits September 8, 2021 17:29

[CoreMedia] Add support for xcode 13 beta 5.

1d39ad1

Merge branch 'main' into coremedia-xcode13-beta5

7df3012

[CoreMedia] Add support xcode13 beta 5.

232d489

Merge branch 'main' into coremedia-xcode13-beta5

bee5633

Add missing tests and fix deprecation after the merge.

6e82f35

Merge branch 'main' into coremedia-xcode13-beta5

a9eda1b

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Sep 17, 2021

mandel-macaque requested a review from dalexsoto as a code owner September 17, 2021 17:44

dalexsoto approved these changes Sep 17, 2021

View reviewed changes

rolfbjarne requested changes Sep 20, 2021

View reviewed changes

tj-devel709 reviewed Sep 20, 2021

View reviewed changes

src/CoreMedia/CMSync.cs Outdated Show resolved Hide resolved

mandel-macaque and others added 3 commits September 20, 2021 11:34

Apply suggestions from code review

446035b

Co-authored-by: TJ Lambert <[email protected]> Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

Address reviews.

ccded67

Merge branch 'coremedia-xcode13-beta5' of github.com:mandel-macaque/x…

5040693

…amarin-macios into coremedia-xcode13-beta5

mandel-macaque added 2 commits September 21, 2021 13:55

Fix intro tests.

1999eae

Merge branch 'main' into coremedia-xcode13-beta5

a952f2a

rolfbjarne approved these changes Sep 24, 2021

View reviewed changes

mandel-macaque and others added 2 commits September 24, 2021 12:25

Apply suggestions from code review

7bd6836

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

Fix Catalyst intro.

d43c6db

mandel-macaque merged commit ad673ae into xamarin:main Sep 24, 2021

mandel-macaque deleted the coremedia-xcode13-beta5 branch September 24, 2021 22:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CoreMedia] Add support for xcode13 #12770

[CoreMedia] Add support for xcode13 #12770

mandel-macaque commented Sep 17, 2021

vs-mobiletools-engineering-service2 commented Sep 17, 2021

Failed tests

tj-devel709 Sep 20, 2021

mandel-macaque Sep 20, 2021 •

edited

Loading

tj-devel709 Sep 20, 2021

mandel-macaque Sep 20, 2021

tj-devel709 Sep 20, 2021

tj-devel709 Sep 20, 2021

vs-mobiletools-engineering-service2 commented Sep 20, 2021

Failed tests

vs-mobiletools-engineering-service2 commented Sep 24, 2021

Failed tests

rolfbjarne Sep 20, 2021

vs-mobiletools-engineering-service2 commented Sep 24, 2021

Failed tests

mandel-macaque commented Sep 24, 2021

vs-mobiletools-engineering-service2 commented Sep 24, 2021

vs-mobiletools-engineering-service2 commented Sep 24, 2021

		@@ -411,20 +468,30 @@ public CMTimebaseError SetTimerToFireImmediately (NSTimer timer)

		#if !NET
		[TV (13,0), Mac (10,15), iOS (13,0)]

		@@ -436,20 +503,30 @@ public CMTimebaseError SetMasterTimebase (CMTimebase newMasterTimebase)

		#if !NET
		[TV (13,0), Mac (10,15), iOS (13,0)]

[CoreMedia] Add support for xcode13 #12770

[CoreMedia] Add support for xcode13 #12770

Conversation

mandel-macaque commented Sep 17, 2021

vs-mobiletools-engineering-service2 commented Sep 17, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

tj-devel709 Sep 20, 2021

Choose a reason for hiding this comment

mandel-macaque Sep 20, 2021 • edited Loading

Choose a reason for hiding this comment

tj-devel709 Sep 20, 2021

Choose a reason for hiding this comment

mandel-macaque Sep 20, 2021

Choose a reason for hiding this comment

tj-devel709 Sep 20, 2021

Choose a reason for hiding this comment

tj-devel709 Sep 20, 2021

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 20, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 24, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rolfbjarne Sep 20, 2021

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 24, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

mandel-macaque commented Sep 24, 2021

vs-mobiletools-engineering-service2 commented Sep 24, 2021

vs-mobiletools-engineering-service2 commented Sep 24, 2021

mandel-macaque Sep 20, 2021 •

edited

Loading