Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule MonoTouch.Dialog. #13058

Merged
merged 11 commits into from
Oct 26, 2021

Commits on Oct 20, 2021

  1. Submodule MonoTouch.Dialog.

    Submodule MonoTouch.Dialog, so that we can easily build it using .NET. This
    submodule will become redundant when/if we publish a .NET version of
    MonoTouch.Dialog, but until that happens we need it at least for our own test
    suites.
    
    This also means we have to copy our NuGet.config and global.json files to the
    MonoTouch.Dialog project directory so that we point msbuild to use our local
    build.
    
    New commits in spouliot/Touch.Unit:
    
    * xamarin/Touch.Unit@cbda703 [Touch.Client] Use MonoTouch.Dialog from a submodule. (xamarin#109)
    
    Diff: https://github.com/spouliot/Touch.Unit/compare/3345db2f4e6408fdf2e8f099251c5c1310b56937..cbda70358360329854ea399100a2b5b04ae43982
    rolfbjarne committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    ac3148c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Use relative path for submodule.

    And fix indentation and set the branch name.
    rolfbjarne committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    c053946 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4079ab7 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. [tests] Our test projects don't need to reference MonoTouch.Dialog di…

    …rectly.
    
    The projects get the MonoTouch.Dialog reference indirectly through the
    Touch.Client project reference.
    rolfbjarne committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    988aa20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df04bb8 View commit details
    Browse the repository at this point in the history
  3. [tests] No need to reference System.Json anymore, that's handled dire…

    …ctly in the MonoTouch.Dialog project.
    rolfbjarne committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    3d726e7 View commit details
    Browse the repository at this point in the history
  4. [tests] Reference nunit.framework.targets so we get a workaround for …

    …an NUnit issue everywhere.
    rolfbjarne committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    6b3e9be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a345aa4 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. [msbuild] Only try to create a package if we're able to create an app…

    … bundle.
    
    This fixes an issue where a library project would try (and fail) to create a
    package when 'CreatePackage=true' (which could be set for the executable
    project, but inherited by the library project since the executable project
    depends on it).
    rolfbjarne committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    382b4e2 View commit details
    Browse the repository at this point in the history
  2. [tests] Adjust PackTest.BindingXcFrameworksProject to not set the Ass…

    …emblyName property.
    
    MSBuild ends up being very confused when the project we're trying to build
    depends on other projects, because AssemblyName is set for all the projects
    being build, and MSBuild complains about ambiguous projects:
    
    > error: Ambiguous project name 'bindings-xcframework-test'
    rolfbjarne committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    75d0a34 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    63a17e6 View commit details
    Browse the repository at this point in the history