[.NET] Move the nfloat type to the ObjCRuntime namespace for .NET. #13092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move the NMath type from the System namespace to the ObjCRuntime namespace.
rolfbjarne
added
not-notes-worthy
tj-devel709
approved these changes
Oct 22, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results50 tests failed, 86 tests passed.Failed tests
Pipeline on Agent XAMBOT-1102.BigSur' |
|
This depends on #13058 first. |
rolfbjarne
added
breaking-change
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results46 tests failed, 90 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
github-actions bot
pushed a commit
to dotnet/runtime
that referenced
this pull request
Oct 26, 2021
… Xamarin.MacCatalyst.dll as well. Ref: xamarin/xamarin-macios#13092 Ref: mono/mono#21261
New commits in migueldeicaza/MonoTouch.Dialog: * migueldeicaza/MonoTouch.Dialog@5a05c69 Add additional usings now that nfloat can be in ObjCRuntime. Diff: https://github.com/migueldeicaza/MonoTouch.Dialog/compare/8e60f82a1ab0fba5e798624edd488736870bb0d7..5a05c6912ef3828271557d9daaaec172c5fb45c2
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 131 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results45 tests failed, 97 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur |
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@cbda703 [Touch.Client] Use MonoTouch.Dialog from a submodule. Diff: https://github.com/spouliot/Touch.Unit/compare/3345db2f4e6408fdf2e8f099251c5c1310b56937..cbda70358360329854ea399100a2b5b04ae43982
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 141 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2414). |
akoeplinger
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 3, 2021
… Xamarin.MacCatalyst.dll as well. (#60854) Ref: xamarin/xamarin-macios#13092 Ref: mono/mono#21261
akoeplinger
pushed a commit
to mono/mono
that referenced
this pull request
Nov 3, 2021
… Xamarin.MacCatalyst.dll as well. (#21261) Ref: xamarin/xamarin-macios#13092
akoeplinger
pushed a commit
to mono/mono
that referenced
this pull request
Nov 3, 2021
… Xamarin.MacCatalyst.dll as well. (#21263) Ref: xamarin/xamarin-macios#13092 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
Anipik
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 11, 2021
… Xamarin.MacCatalyst.dll as well. (#60861) Ref: xamarin/xamarin-macios#13092 Ref: mono/mono#21261 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move the NMath type from the System namespace to the ObjCRuntime namespace.