-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIP] Updates for Xcode13.2 beta 1 #13884
Conversation
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffView dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results4 tests failed, 104 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was quite the read! Good job
@rolfbjarne Thanks for the quick and thorough review as always! |
Perhaps add an issue for this |
src/chip.cs
Outdated
@@ -70,7 +73,6 @@ public enum ChipOptionalQRCodeInfoType : ulong { | |||
Int32, | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra new line
❌ [PR Build] Tests didn't execute on Build. ❌Tests didn't execute on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): No test summary was found (something probably failed before the tests could execute) |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 105 tests passed.Failed tests
Pipeline on Agent XAMBOT-1042.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lot of todo entries can/must be removed from xtro as well :)
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 107 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 146 tests passed.Failed tests
Pipeline on Agent XAMBOT-1098.BigSur' |
Test failures are known and unrelated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are the following breaking changes:
Chip.ChipBinaryInputBasic
Modified methods:
-public virtual void WriteAttributeOutOfService (byte value, ChipResponseHandler responseHandler)
+public void WriteAttributeOutOfService (byte value, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task WriteAttributeOutOfServiceAsync (byte value)
+public System.Threading.Tasks.Task WriteAttributeOutOfServiceAsync (byte value)
-public virtual void WriteAttributePresentValue (byte value, ChipResponseHandler responseHandler)
+public void WriteAttributePresentValue (byte value, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task WriteAttributePresentValueAsync (byte value)
+public System.Threading.Tasks.Task WriteAttributePresentValueAsync (byte value)
Chip.ChipBinding
-public virtual void Bind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
+public void Bind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task BindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)
+public System.Threading.Tasks.Task BindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)
-public virtual void Unbind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
+public void Unbind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task UnbindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)
+public System.Threading.Tasks.Task UnbindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)
Chip.ChipTemperatureMeasurement
-public virtual void WriteAttributeBoolean (byte value, ChipResponseHandler responseHandler)
+public void WriteAttributeBoolean (byte value, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task WriteAttributeBooleanAsync (byte value)
+public System.Threading.Tasks.Task WriteAttributeBooleanAsync (byte value)
Please take a look at the full diff in the comment from the bots. You are probably missing virtual from some manual code you added to not change the api.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 147 tests passed.Failed tests
Pipeline on Agent XAMBOT-1109.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results4 tests failed, 144 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
API Current PR diffView dotnet API diffView dotnet legacy API diffView dotnet iOS-MacCatalayst API diff
Generator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 148 tests passed 🎉Pipeline on Agent XAMBOT-1109.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply the small cleaning comments.
src/Chip/ChipCompat.cs
Outdated
// | ||
// Authors: | ||
// Rachel Kang <[email protected]> | ||
//com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//com |
src/Chip/ChipKeypair.cs
Outdated
// | ||
// Authors: | ||
// Rachel Kang <[email protected]> | ||
//com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//com |
CHIP updates for Xcode13.2 beta 1
Related notes: