[runtime] Remove ObjCRuntime.nfloat in favor of System.Runtime.InteropServices.NFloat. #14197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arin#12922. We can't execute mono's C# compiler when using .NET, so we need to tell bgen where csc is in that case. Fixes xamarin#12922.
… to get the new nfloat API.
…loat.Internal so that the new System.Runtime.InteropServices.NFloat API can be used. This is only for .NET 6, once we switch to .NET 7 we don't need this anymore.
…ct it into compilations. This can be turned off by passing /no-nfloat-using:true to bgen (which can be done by setting NoNFloatUsing=true in the project file).
…eCLR runtime pack selection.
rolfbjarne
added
not-notes-worthy
spouliot
reviewed
Feb 18, 2022
| @@ -38,7 +38,7 @@ namespace Introspection { | |||
|
|
|||
| public abstract class ApiSignatureTest : ApiBaseTest { | |||
| #if NET | |||
| const string NFloatTypeName = "ObjCRuntime.nfloat"; | |||
| const string NFloatTypeName = "System.Runtime.InteropServices.nfloat"; | |||
There was a problem hiding this comment.
This has been fixed now.
This comment was marked as outdated.
This comment was marked as outdated.
mauroa
approved these changes
Feb 23, 2022
chamons
approved these changes
Feb 23, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 234 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2542) |
mandel-macaque
approved these changes
Feb 23, 2022
emaf
approved these changes
Feb 24, 2022
tj-devel709
pushed a commit
to tj-devel709/xamarin-macios
that referenced
this pull request
Mar 8, 2022
…pServices.NFloat. (xamarin#14197) * Remove ObjCRuntime.nfloat (in favor of System.Runtime.InteropServices.NFloat). * Automatically add a reference to the System.Runtime.InteropServices.Internal package, so that developers get the new NFloat API (with operators) we've added post .NET 6 (but don't do this for .NET 7). * Automatically add a global using alias for System.Runtime.InteropServices.NFloat -> nfloat. This is not behind the usual `ImplicitUsings` condition our other implicit usings are, because they're off by default for existing projects, and the main target for the global using alias for nfloat is upgraded projects. * Automatically generate a global using alias (like above) in the generator for all code the generator compiles. * Update xtro entries to reference System.Runtime.InteropServices.NFloat instead of ObjCRuntime.nfloat. * Add a workaround for a hopefully temporary issue with .NET/CoreCLR where the wrong runtime pack is selected otherwise (without the new NFloat API, so nothing works at runtime). Ref: xamarin#13087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package, so that developers get the new NFloat API (with operators) we've
added post .NET 6 (but don't do this for .NET 7).
System.Runtime.InteropServices.NFloat -> nfloat. This is not behind the
usual
ImplicitUsingscondition our other implicit usings are, becausethey're off by default for existing projects, and the main target for the
global using alias for nfloat is upgraded projects.
for all code the generator compiles.
instead of ObjCRuntime.nfloat.
wrong runtime pack is selected otherwise (without the new NFloat API, so
nothing works at runtime).
Ref: #13087