[HealthKit] Update bindings for Xcode 14 beta 1-4 #15612

tj-devel709 · 2022-08-03T07:18:32Z

This one has been a toughy 😮‍💨
@mandel-macaque I am creating the draft PR and here is a gist with the MacModern failures that you mentioned you would take a closer look at: https://gist.github.com/tj-devel709/24f5c63d4b698a0e2387524a0d2666c6

There were also monotouch-test failures that seem to be related to enabling mac that I could use some help with as well.

Lastly, @chamons there was a failing Cecil test regarding ios in DidGenerateEvent method found here: https://gist.github.com/tj-devel709/2c8aee7325c0c2751e29269d3eb77fef. I did not touch this method so I am not sure why this would be a problem.
Here is the Cecil failure: https://gist.github.com/tj-devel709/cfb2576c75de2ee100a8f2b7ee6e3923

Thanks for the help!

Edit *: Issues mentioned in the code comments
https://github.com/xamarin/maccore/issues/2609
https://github.com/xamarin/maccore/issues/2610

…-Beta1and3

tj-devel709 · 2022-08-03T14:42:27Z

~~Oh interesting, hopefully not related to the other errors, but I missed the api-annotations-dotnet/MacCatalyst-HealthKit.todo file and will get to this later today!~~

Monotouch-Tests iOS also do not seem to like my manual file and/or test - /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/HKCategoryValueSleepAnalysisTest.cs(27,22): error CS0103: The name 'HKCategoryValueSleepAnalysisAsleep' does not exist in the current context [/Users/builder/azdo/_work/1/s/xamarin-macios/tests/xharness/tmp-test-dir/monotouch-test21/monotouch-test.csproj]

…ode14-HealthKit-Beta1and3

…-Beta1and3

tj-devel709 · 2022-08-24T17:12:41Z

@rolfbjarne Addressed!

dalexsoto · 2022-08-25T17:56:17Z

src/healthkit.cs

+
+		[Watch (9,0), MacCatalyst (16,0), Mac (13,0), iOS (16,0), NoTV]
+		[Export ("initWithRoute:dateInterval:dataHandler:")]
+		NativeHandle Constructor (HKWorkoutRoute workoutRoute, NSDateInterval dateInterval, Action<HKWorkoutRouteQuery, NSArray<CLLocation>, bool, NSError> dataHandler);


This needs a dotnet array so you will need a custom delegate

delegate void HKWorkoutRouteQueryDataHandler (HKWorkoutRouteQuery query, [NullAllowed] CLLocation [] routeData, bool done, [NullAllowed] NSError error);

dalexsoto · 2022-08-25T18:00:58Z

src/healthkit.cs

+
+		[Async]
+		[Export ("removeAttachment:fromObject:completion:")]
+		void RemoveAttachment (HKAttachment attachment, HKObject @object, Action<bool, NSError> completion);


what does the bool represents here? Probably this is a good candidate to do a delegate instead of an Action, same for the rest in this class.

SotoiGhost

Everything looks good, just address Alex's comments.

SotoiGhost · 2022-08-25T18:11:01Z

src/frameworks.sources

 	GLKit                   \
+	HealthKit \


nit

Suggested change

GLKit \

HealthKit \

GLKit \

HealthKit \

…ode14-HealthKit-Beta1and3

tj-devel709 · 2022-08-27T00:10:13Z

@dalexsoto Updated to use the delegates!

SotoiGhost · 2022-08-27T02:27:40Z

src/healthkit.cs

@@ -564,7 +564,7 @@ interface HKCorrelationType {

 	delegate void HKHealthStoreGetRequestStatusForAuthorizationToShareHandler (HKAuthorizationRequestStatus requestStatus, NSError error);
 	delegate void HKHealthStoreRecoverActiveWorkoutSessionHandler (HKWorkoutSession session, NSError error);
-	delegate void HKHealthStoreCompletionHandler (bool success, [NullAllowed] NSError error);
+	delegate void HKHealthStoreCompletionHandler (bool success, NSError error);


Weird... what was the compiler issue?

Thanks for bringing this up @SotoiGhost !
Here is a gist of the errors / warnings that were not present when not including the [NullAllowed]
https://gist.github.com/tj-devel709/756ac73e32f3ff8ae234d8ba7ecdd7cc

vs-mobiletools-engineering-service2 · 2022-08-31T18:52:34Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~ (no change detected)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~: (empty diff detected)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7975c6ecf3eb6874305a9db4511bf5a155606911 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-31T18:55:19Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 7975c6ecf3eb6874305a9db4511bf5a155606911 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-31T19:08:17Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1169.Monterey
Hash: 7975c6ecf3eb6874305a9db4511bf5a155606911 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-31T19:13:18Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: 7975c6ecf3eb6874305a9db4511bf5a155606911 [PR build]

vs-mobiletools-engineering-service2 · 2022-09-01T00:15:43Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 226 tests passed.

Failures

❌ interdependent_binding_projects tests

1 tests failed, 6 tests passed.

interdependent-binding-projects/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

tj_devel709 added 5 commits July 25, 2022 09:29

starting HealthKit Beta1and3 Xcode 14

850ff73

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-HealthKit…

c47a80f

…-Beta1and3

starting HealthKit Xcode 14 bindings

991ef06

Add a disableDefaultCtor

8483bca

fix the p-invoke manual code and test

af68016

tj-devel709 added the notes-mention Deserves a mention in release notes label Aug 3, 2022

tj-devel709 added this to the xcode14 milestone Aug 3, 2022

This comment has been minimized.

Sign in to view

mandel-macaque added the do-not-merge Do not merge this pull request label Aug 3, 2022

tj_devel709 and others added 2 commits August 3, 2022 12:00

Few extra MacCatalyst things but most were already implemented

00f8c76

Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3

b5577c0

This comment has been minimized.

Sign in to view

tj_devel709 added 2 commits August 3, 2022 17:01

directly use appkit on mac

2d76b02

Merge remote-tracking branch 'TJ/Xcode14-HealthKit-Beta1and3' into Xc…

80653c0

…ode14-HealthKit-Beta1and3

This comment has been minimized.

Sign in to view

tj_devel709 added 2 commits August 4, 2022 11:48

add radar issue with iOS attribute - fix cecil error

af6759e

Merge remote-tracking branch 'xamarin/xcode14' into Xcode14-HealthKit…

7347553

…-Beta1and3

This comment has been minimized.

Sign in to view

add a using statement and spacing

b02c179

Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3

e5789d8

This comment has been minimized.

Sign in to view

dalexsoto requested a review from mandel-macaque August 25, 2022 17:45

dalexsoto requested changes Aug 25, 2022

View reviewed changes

SotoiGhost reviewed Aug 25, 2022

View reviewed changes

tj_devel709 added 3 commits August 26, 2022 13:23

Add Delegates for stronger array types and names

957ffc1

there were compiler issues with these nullallowed

3dbf734

Merge remote-tracking branch 'TJ/Xcode14-HealthKit-Beta1and3' into Xc…

82af5b6

…ode14-HealthKit-Beta1and3

This comment has been minimized.

Sign in to view

SotoiGhost reviewed Aug 27, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Aug 31, 2022

View reviewed changes

Merge branch 'xcode14' into Xcode14-HealthKit-Beta1and3

7975c6e

tj-devel709 merged commit 7bd9838 into xamarin:xcode14 Sep 1, 2022

[HealthKit] Update bindings for Xcode 14 beta 1-4 #15612

[HealthKit] Update bindings for Xcode 14 beta 1-4 #15612

Conversation

tj-devel709 commented Aug 3, 2022 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented Aug 3, 2022 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 commented Aug 24, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto Aug 25, 2022

Choose a reason for hiding this comment

dalexsoto Aug 25, 2022

Choose a reason for hiding this comment

SotoiGhost left a comment

Choose a reason for hiding this comment

SotoiGhost Aug 25, 2022

Choose a reason for hiding this comment

tj-devel709 commented Aug 27, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SotoiGhost Aug 27, 2022

Choose a reason for hiding this comment

tj-devel709 Aug 29, 2022

Choose a reason for hiding this comment

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 31, 2022

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Aug 31, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Aug 31, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Aug 31, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Sep 1, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ interdependent_binding_projects tests

❌ introspection tests

Successes

tj-devel709 commented Aug 3, 2022 •

edited

Loading

tj-devel709 commented Aug 3, 2022 •

edited

Loading