Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Add Xcode 14.3 Support #17810

Merged
merged 39 commits into from
Mar 30, 2023
Merged

[main] Add Xcode 14.3 Support #17810

merged 39 commits into from
Mar 30, 2023

Conversation

dalexsoto
Copy link
Member

@dalexsoto dalexsoto commented Mar 15, 2023 •
edited
Loading

please do review the work done so far, this should be up to date to Xcode 14.3 Beta 2. Best way to review this is going commit by commit

@dalexsoto dalexsoto added this to the xcode14.3 milestone Mar 15, 2023
@github-actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@dalexsoto dalexsoto self-assigned this Mar 16, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne requested changes Mar 16, 2023
View reviewed changes
src/authenticationservices.cs Outdated
@@ -1598,7 +1612,7 @@ interface ASAuthorizationProviderExtensionLoginManager {
}

[NoWatch, NoTV, NoiOS, NoMacCatalyst, Mac (13, 0)]
[Protocol]
[Protocol][Model]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

#if NET
	[Protocol, Model]
#else
	[Protocol, Model (AutoGeneratedName = true)]
#endif

src/MediaAccessibility/MediaAccessibility.cs Outdated Show resolved Hide resolved
src/MediaAccessibility/MediaAccessibility.cs Outdated Show resolved Hide resolved
src/authenticationservices.cs Outdated Show resolved Hide resolved
src/authenticationservices.cs Show resolved Hide resolved
tests/xtro-sharpie/api-annotations-dotnet/macOS-MediaPlayer.ignore Outdated Show resolved Hide resolved
tests/xtro-sharpie/macOS-MediaPlayer.ignore Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
tj-devel709
tj-devel709 reviewed Mar 17, 2023
View reviewed changes
src/avrouting.cs Outdated Show resolved Hide resolved
tj-devel709
tj-devel709 reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far! Left one comment about a possibly missing MacCatalyst

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4d98f09877c039bb06c92cdd93017fc1578382e8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 4d98f09877c039bb06c92cdd93017fc1578382e8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 4d98f09877c039bb06c92cdd93017fc1578382e8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1035.Ventura
Hash: 4d98f09877c039bb06c92cdd93017fc1578382e8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 4d98f09877c039bb06c92cdd93017fc1578382e8 [PR build]

@dalexsoto
Copy link
Member Author

/sudo backport xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch xcode14.3 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7553245 for more details.

@dalexsoto dalexsoto changed the title [xcode14.3] Add Xcode 14.3 Support [main] [xcode14.3] Add Xcode 14.3 Support Mar 30, 2023
@dalexsoto
Copy link
Member Author

/sudo backport release/7.0.2xx-xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7553313 for more details.

@dalexsoto dalexsoto changed the title [main] [xcode14.3] Add Xcode 14.3 Support [main] Add Xcode 14.3 Support Mar 30, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne rolfbjarne mentioned this pull request Mar 30, 2023
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4d98f09877c039bb06c92cdd93017fc1578382e8 [PR build]

@dalexsoto dalexsoto merged commit bae2dd5 into xamarin:main Mar 30, 2023
@dalexsoto dalexsoto deleted the xcode14.3-update branch March 30, 2023 16:11
dalexsoto added a commit that referenced this pull request Mar 30, 2023
@dalexsoto
[xcode14.3] Add Xcode 14.3 Support (#17942)
a551ed0 
This is a draft PR but please do review the work done so far, this
should be up to date to Xcode 14.3 Beta 2. Best way to review this is
going commit by commit


Backport of #17810
dalexsoto added a commit that referenced this pull request Mar 30, 2023
@dalexsoto
[release/6.0.4xx-xcode14.3] Add Xcode 14.3 Support (#17946)
2f729d3 
This is a backport of #17810 and #17062.
dalexsoto added a commit that referenced this pull request Mar 30, 2023
@dalexsoto
[release/7.0.2xx-xcode14.3] Add Xcode 14.3 Support (#17943)
dd59218 
This is a draft PR but please do review the work done so far, this
should be up to date to Xcode 14.3 Beta 2. Best way to review this is
going commit by commit


Backport of #17810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709

Assignees

@dalexsoto dalexsoto

Labels
None yet
Projects
None yet
Milestone
xcode14.3
Development

Successfully merging this pull request may close these issues.
5 participants
@dalexsoto @vs-mobiletools-engineering-service2 @rolfbjarne @mandel-macaque @tj-devel709