Bring changes from Localization branch #20230811.5 #18713
Conversation
LEGO: Merge pull request 18712
vs-mobiletools-engineering-service2
added
the
not-notes-worthy
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LEGO: Merge pull request 18714
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
✅ Generator diffGenerator diff is empty Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 235 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
In my Localization inspection, I wanted to figure out why the automated PRs I was creating in Pipelines were auto-closing themselves a few hours after creating them - [example](#18713). There are a few different steps in the localization process and long story short is that I am creating these PRs from the Localization branch. Each commit into main runs a tool that alerts the Loc team and it syncs up our Localization branch to our main branch which temporarily deletes our Localization branch thus closing the automated PR! This PR creates a new unique branch for each Localization PR so that we can keep updating the Loc team, but also make sure syncing the Localization branch will not delete this PR. Testing this created this PR below: #18880
The OneLoc team creates these translations to be consumed later on in the second step of the Localization process. We need to bring these into the main branch in order to continue the process.