[NativeAOT] Do not root platform assembly

[simonrozsival]

Closes #18779

Based on testing several MAUI samples, there doesn't seem to be a reason to root the whole platform assembly anymore.

[ivanpovazan]

Thank you!

PS Additionally this would also complete #18584

[simonrozsival]

The MonoTouchFixtures.ARKit.ARConfigurationTest.Subclasses test (#5348) is failing:

xamarin-macios/tests/monotouch-test/ARKit/ARConfigurationTest.cs

Lines 50 to 62 in cd69385

	[Test]
	public void Subclasses ()
	{
	// note: this can be run on any xcode / OS version since it's reflection only
	// all subclasses of ARConfiguration must (re)export 'GetSupportedVideoFormats'
	var c = typeof (ARConfiguration);
	foreach (var sc in c.Assembly.GetTypes ()) {
	if (!sc.IsSubclassOf (c))
	continue;
	var m = sc.GetMethod ("GetSupportedVideoFormats", BindingFlags.Static | BindingFlags.Public);
	Assert.NotNull (m, sc.FullName);
	}
	}

I think this can be expected when we don't root the whole assembly. I'm not sure what the correct fix is and if this test is even necessary in the NativeAOT configuration 🤔

[rolfbjarne]

The MonoTouchFixtures.ARKit.ARConfigurationTest.Subclasses test (#5348) is failing:

xamarin-macios/tests/monotouch-test/ARKit/ARConfigurationTest.cs

Lines 50 to 62 in cd69385

	[Test]
	public void Subclasses ()
	{
	// note: this can be run on any xcode / OS version since it's reflection only
	// all subclasses of ARConfiguration must (re)export 'GetSupportedVideoFormats'
	var c = typeof (ARConfiguration);
	foreach (var sc in c.Assembly.GetTypes ()) {
	if (!sc.IsSubclassOf (c))
	continue;
	var m = sc.GetMethod ("GetSupportedVideoFormats", BindingFlags.Static | BindingFlags.Public);
	Assert.NotNull (m, sc.FullName);
	}
	}

I think this can be expected when we don't root the whole assembly. I'm not sure what the correct fix is and if this test is even necessary in the NativeAOT configuration 🤔

This should fix it: #18908

[vs-mobiletools-engineering-service2]

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0028b0c067e543a8fd77eaa70dc5437ea4767539 [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• xamarin.ios-16.5.0.852.pkg
• xamarin.mac-9.4.0.852.pkg

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

[vs-mobiletools-engineering-service2]

🔥 Failed to compare API and create generator diff 🔥

Failed to run apidiff

Pipeline on Agent
Hash: 0028b0c067e543a8fd77eaa70dc5437ea4767539 [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 233 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0028b0c067e543a8fd77eaa70dc5437ea4767539 [PR build]