[test][introspection] Enable MtouchNoSymbolStrip for device builds in order to avoid linking symbols needed by test #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spouliot
approved these changes
Jun 9, 2017
|
If not the case for release then it should be fixed too. Both config should work without errors in devices (and sims) |
|
Build success |
… order to avoid linking symbols meeded by test Rolf Kvinge [8:59 AM] @dalexsoto the fix is to not strip the executable please PR that (it should probably go into master as well). This probably started happening when Jeff implemented support for stripping debug builds (previously the setting was ignored)
|
Build failure |
dalexsoto
changed the title
|
Indeed it was also needed for release, good catch |
|
Build success |
rolfbjarne
approved these changes
Jun 9, 2017
dalexsoto
added a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Jun 10, 2017
… order to avoid linking symbols meeded by test (xamarin#2196) Rolf Kvinge [8:59 AM] @dalexsoto the fix is to not strip the executable please PR that (it should probably go into master as well). This probably started happening when Jeff implemented support for stripping debug builds (previously the setting was ignored)
rolfbjarne
pushed a commit
that referenced
this pull request
Jun 10, 2017
#2191) * [Test][Intro] Fix introspection test on API changes for Xcode 9 Beta 1 * [introspection] Fix feedback from PR and bot tests Removed XAMCORE_4_0 checks from our api definition, and added a file with stubs for all of them instead. Cleaner binding file and easier to remove in the future Fixed introspection also for mac by moving some check into base test definition * [CoreImage] Add CoreImage stubs so introspection test are happy These need to be manually reviewed by whoever takes CoreImage framework tracked in bugzilla so we do not forget * Do the same API cleanup as in NSUnit * [test][introspection] Enable MtouchNoSymbolStrip for device builds in order to avoid linking symbols meeded by test (#2196) Rolf Kvinge [8:59 AM] @dalexsoto the fix is to not strip the executable please PR that (it should probably go into master as well). This probably started happening when Jeff implemented support for stripping debug builds (previously the setting was ignored) * [foundation] Provide better messages * [CoreImage] Fix Availability of CIEdgePreserveUpsampleFilter
dalexsoto
added a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
May 21, 2020
New commits in xamarin/maccore: * xamarin/maccore@4bfce64847 Update README.md * xamarin/maccore@24682998f7 [devops] Enhance Xcode renaming script (xamarin#2206) * xamarin/maccore@e03f16b862 [Localization][Mlaunch] Fix watchos timeout issue (xamarin#2196) Diff: https://github.com/xamarin/maccore/compare/ad1696d6f33badd34f930e4ce1be9185b5a36dd7..4bfce648475f8db1d93b8a9f51a69ad0b8b55930
dalexsoto
added a commit
that referenced
this pull request
May 21, 2020
…8643) New commits in xamarin/maccore: * xamarin/maccore@4bfce64847 Update README.md * xamarin/maccore@24682998f7 [devops] Enhance Xcode renaming script (#2206) * xamarin/maccore@e03f16b862 [Localization][Mlaunch] Fix watchos timeout issue (#2196) Diff: https://github.com/xamarin/maccore/compare/ad1696d6f33badd34f930e4ce1be9185b5a36dd7..4bfce648475f8db1d93b8a9f51a69ad0b8b55930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From our conversation earlier today
Rolf Kvinge [8:59 AM]
@dalexsoto the fix is to not strip the executable please PR that
(it should probably go into master as well). This probably started
happening when Jeff implemented support for stripping debug builds
(previously the setting was ignored)
will be backported to xcode9 once approved