[Accounts] Update to Xcode 9 Beta 1 #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spouliot
approved these changes
Jun 10, 2017
src/accounts.cs
Outdated
| @@ -112,6 +113,12 @@ interface ACAccountStore { | |||
| [Wrap ("RequestAccess (accountType, options == null ? null : options.Dictionary, completion)")] | |||
| [Async] | |||
| void RequestAccess (ACAccountType accountType, [NullAllowed] AccountStoreOptions options, ACRequestCompletionHandler completion); | |||
|
|
|||
| // For some reason this was never added before, xtro caught it. | |||
There was a problem hiding this comment.
Move this to the commit message
There was a problem hiding this comment.
We had nothing missing for iOS in xtro...
If it was in a data file it should be removed
There was a problem hiding this comment.
Nope, it was inside common.unclassified so likely it wasn't spotted by accident
common.unclassified:!missing-selector! ACAccountStore::removeAccount:withCompletionHandler: not bound
There was a problem hiding this comment.
Ok, let's remove it from that file then
And add the mac attribute
Also added ACAccountStore.RemoveAccount, xtro caught this API common.unclassified:!missing-selector! ACAccountStore::removeAccount:withCompletionHandler: not bound
|
Build failure |
1 similar comment
|
Build failure |
src/accounts.cs
Outdated
| @@ -127,29 +133,40 @@ interface ACAccountType : NSSecureCoding { | |||
| [Export ("accessGranted")] | |||
| bool AccessGranted { get; } | |||
|
|
|||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Twitter SDK instead")] | |||
There was a problem hiding this comment.
https://github.com/xamarin/xamarin-macios/wiki/BINDINGS#availability-attributes-messages (:
Please add a dot at the end of the sentance.
src/accounts.cs
Outdated
| @@ -127,29 +133,40 @@ interface ACAccountType : NSSecureCoding { | |||
| [Export ("accessGranted")] | |||
| bool AccessGranted { get; } | |||
|
|
|||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Twitter SDK instead")] | |||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use Twitter SDK instead")] | |||
src/accounts.cs
Outdated
| [Field ("ACAccountTypeIdentifierTwitter")] | ||
| NSString Twitter { get; } | ||
|
|
||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Sina Weibo SDK instead")] | ||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use Sina Weibo SDK instead")] |
src/accounts.cs
Outdated
| [Since (6,0)] | ||
| [Field ("ACAccountTypeIdentifierSinaWeibo")] | ||
| NSString SinaWeibo { get; } | ||
|
|
||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Facebook SDK instead")] | ||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use Facebook SDK instead")] |
src/accounts.cs
Outdated
| [Since (6,0)] | ||
| [Field ("ACAccountTypeIdentifierFacebook")] | ||
| NSString Facebook { get; } | ||
|
|
||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Tencent Weibo SDK instead")] | ||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use Tencent Weibo SDK instead")] |
src/accounts.cs
Outdated
| [Since (7,0)] | ||
| [Mac (10,9)] | ||
| [Field ("ACAccountTypeIdentifierTencentWeibo")] | ||
| NSString TencentWeibo { get; } | ||
|
|
||
| #if MONOMAC | ||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use LinkedIn SDK instead")] |
src/accounts.cs
Outdated
| [Mac (10,9)] | ||
| [Field ("ACAccountTypeIdentifierLinkedIn")] | ||
| NSString LinkedIn { get; } | ||
| #endif | ||
| } | ||
|
|
||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Facebook SDK instead")] | ||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use Facebook SDK instead")] |
src/accounts.cs
Outdated
| @@ -165,6 +182,8 @@ interface ACFacebookKey { | |||
| NSString Audience { get; } | |||
| } | |||
|
|
|||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Facebook SDK instead")] | |||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use Facebook SDK instead")] | |||
src/accounts.cs
Outdated
| @@ -180,6 +199,8 @@ interface ACFacebookAudienceValue | |||
| NSString OnlyMe { get; } | |||
| } | |||
|
|
|||
| [Deprecated (PlatformName.iOS, 11, 0, message: "Use Tencent Weibo SDK instead")] | |||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use Tencent Weibo SDK instead")] | |||
src/accounts.cs
Outdated
| @@ -189,6 +210,7 @@ interface ACTencentWeiboKey { | |||
| } | |||
|
|
|||
| #if MONOMAC | |||
| [Deprecated (PlatformName.MacOSX, 10, 13, message: "Use LinkedIn SDK instead")] | |||
VincentDondain
requested changes
Jun 12, 2017
|
@VincentDondain please create an intro test to check for this (and other comments you add like quotes) |
|
@VincentDondain Fixed, thanks! |
VincentDondain
approved these changes
Jun 12, 2017
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Into and xtro are happy locally 😄