Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CallKit] Update to Xcode 9 Beta 1 #2207

Merged
merged 2 commits into from
Jun 13, 2017
Merged

Conversation

dalexsoto
Copy link
Member

No description provided.

@monojenkins
Copy link
Collaborator

Build failure

src/callkit.cs Outdated
@@ -68,6 +68,8 @@ public enum CXErrorCodeCallDirectoryManagerError : nint {
MaximumEntriesExceeded = 5,
ExtensionDisabled = 6,
CurrentlyLoading = 7,
[iOS (11, 0)]
Copy link
Contributor

@VincentDondain VincentDondain Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but [iOS (11,0)] is prettier (note: you sometimes use this in this diff).

@monojenkins
Copy link
Collaborator

Build success

@dalexsoto dalexsoto merged commit ec01653 into xamarin:xcode9 Jun 13, 2017
@dalexsoto dalexsoto deleted the callkitb1 branch June 13, 2017 23:02
dalexsoto added a commit that referenced this pull request May 21, 2020
* [xcode11.5] Initial bump to support Xcode 11.5 Beta GM (#8624)

New commits in xamarin/maccore:

* xamarin/maccore@27e82f1595 [devops] Enhance Xcode renaming script (#2207)

Diff: https://github.com/xamarin/maccore/compare/f60e7880edd3dd95f0315c094868d6ae1e64559c..27e82f15953ba287ff8ba5f4d0114978899028a1

* [xcode11.5] Bump to Xcode 11.5 Final and include provisionator changes (#8634)

* [xcode11.5] Bump to use Xcode 11.5 GA and new Xcode naming

* [Devops] Move to use provisionator to get xcode.

Move to use the provisionator and add a make file to generate the script
so that we only have to bump xcode in a single place.

Move all deps to provisionator and make provisionator download and
install the xi pkg that has been built to be tested in the pipeline, we
do not longer use curl to do it.

Co-authored-by: Manuel de la Pena <[email protected]>

* Apply feedback

Co-authored-by: Manuel de la Pena <[email protected]>

* Fix old-style provisioning by using a non-composed variable for XCODE_URL. (#8641)

Fixes this:

    Checking system...
        Found OSX 10.15.3 (at least 10.15 is required)
            Downloading Xcode 11.5 from http://xamarin-storage/bot-provisioning/xcodes/$(XCODE_XIP_NAME) to /tmp/x-provisioning...

Co-authored-by: Manuel de la Pena <[email protected]>
Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants