[ClockKit] Update to Xcode 9 Beta 1 #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure |
spouliot
approved these changes
Jun 11, 2017
VincentDondain
requested changes
Jun 12, 2017
src/clockkit.cs
Outdated
| @@ -53,16 +53,20 @@ interface CLKComplicationDataSource { | |||
| [Export ("getTimelineEntriesForComplication:afterDate:limit:withHandler:")] | |||
| void GetTimelineEntriesAfterDate (CLKComplication complication, NSDate afterDate, nuint limit, Action<CLKComplicationTimelineEntry []> handler); | |||
|
|
|||
| [Deprecated (PlatformName.WatchOS, 4, 0, message: "Use WKRefreshBackgroundTask instead")] | |||
There was a problem hiding this comment.
Please take a look at https://github.com/xamarin/xamarin-macios/wiki/BINDINGS#availability-attributes-messages as a refresher (:
Your message should be Use 'WKRefreshBackgroundTask' instead.
src/clockkit.cs
Outdated
| [Export ("getNextRequestedUpdateDateWithHandler:")] | ||
| void GetNextRequestedUpdateDate (Action<NSDate> handler); | ||
|
|
||
| [Deprecated (PlatformName.WatchOS, 4, 0, message: "Use `WKRefreshBackgroundTask` instead")] |
There was a problem hiding this comment.
https://github.com/xamarin/xamarin-macios/wiki/BINDINGS#rule-2 please use apostrophes not grave accent (and add a dot at the end) (:
src/clockkit.cs
Outdated
| [Export ("requestedUpdateDidBegin")] | ||
| void RequestedUpdateDidBegin (); | ||
|
|
||
| [Deprecated (PlatformName.WatchOS, 4, 0, message: "Use `WKRefreshBackgroundTask` instead")] |
src/clockkit.cs
Outdated
| [Export ("requestedUpdateBudgetExhausted")] | ||
| void RequestedUpdateBudgetExhausted (); | ||
|
|
||
| // this was @required in watchOS 2.x but is now deprecated and downgraded to @optional in watchOS 3 (betas) | ||
| [Deprecated (PlatformName.WatchOS, 3, 0, message: "Use `GetLocalizableSampleTemplate` instead")] |
|
@VincentDondain Done! And thanks for the refresher! |
VincentDondain
approved these changes
Jun 12, 2017
|
Build success |
rolfbjarne
approved these changes
Jun 13, 2017
dalexsoto
added a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
May 21, 2020
New commits in xamarin/maccore: * xamarin/maccore@ef861db73e [devops] Enhance Xcode renaming script (xamarin#2208) Diff: https://github.com/xamarin/maccore/compare/92a06f73033c07fe97735c1fa10e2fa0a9222c79..ef861db73e7c0f74131d08d5afa64841d6b00e0b
dalexsoto
added a commit
that referenced
this pull request
May 21, 2020
) New commits in xamarin/maccore: * xamarin/maccore@ef861db73e [devops] Enhance Xcode renaming script (#2208) Diff: https://github.com/xamarin/maccore/compare/92a06f73033c07fe97735c1fa10e2fa0a9222c79..ef861db73e7c0f74131d08d5afa64841d6b00e0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.