-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mapkit] Add new bindings up to beta 3 #2334
Conversation
src/mapkit.cs
Outdated
MKAnnotationView ClusterAnnotationView { get; } | ||
|
||
[TV (11,0)][iOS (11,0)][Mac (10,13, onlyOn64: true)] | ||
[Advice ("Pre-defined constants are available from `MKFeatureDisplayPriority`.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to turn ` into ' here -> 'MKFeatureDisplayPriority'
} | ||
|
||
[TV (11,0)][NoWatch][iOS (11,0)][NoMac] | ||
[BaseType (typeof (UIView))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need a DisableDefaultCtor here? also since this inherits from UIView, maybe we also need the initWithFrame
ctor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the API to create this UI item I do not think you're allowed to set the frame of that UI element. If I'm wrong this it's easy to add later. However good call on [DisableDefaultCtor]
.
} | ||
|
||
[NoTV][iOS (11,0)][NoWatch][NoMac] | ||
[BaseType (typeof (UIView))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, maybe DisableDefaultCtor here and inline initWithFrame
ctor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the API to create this UI item I do not think you're allowed to set the frame of that UI element. If I'm wrong this it's easy to add later. However good call on [DisableDefaultCtor]
.
Build failure |
Build failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Build success |
No description provided.