[wkwebkit] Update for beta 4 #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: WKWindowFeatures.h is not compiled (part of the framework umbrella) and the `@interface WKWindowFeatures (WKPrivate)` sounds like it should not have been exposed (it's all fields starting with `_`)
|
Build success |
dalexsoto
approved these changes
Jul 25, 2017
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jan 18, 2021
New commits in xamarin/maccore: * xamarin/maccore@55a700bb5b [build] Add /restore to Xamarin.Analysis build (xamarin#2366) Removed commits from xamarin/maccore: * xamarin/maccore@c42b49fd29 [build] Add /restore to Xamarin.Analysis build Diff: https://github.com/xamarin/maccore/compare/c42b49fd298377220a53070a2b3a25d3274d7f79..55a700bb5ba3c092f511075d479d82ecb10fa5fe
rolfbjarne
added a commit
that referenced
this pull request
Jan 20, 2021
New commits in xamarin/maccore: * xamarin/maccore@55a700bb5b [build] Add /restore to Xamarin.Analysis build (#2366) * xamarin/maccore@2d9f8a9685 Bump to xamarin/xamarin-analysis@95245313 (#2362) * xamarin/maccore@428964bf32 [Device tests] Remove all the code related with vsts pipelines. (#2344) * xamarin/maccore@3875d125da Ignore vscode config files. (#2343) * xamarin/maccore@55ca0540ef [Actions] Add a rebase action. (#2341) * xamarin/maccore@d0bad0f87a [Actions] Add the backport action. (#2340) Diff: https://github.com/xamarin/maccore/compare/5133d2cea1c52fb783f64ab2ba97c760cf33f5f4..55a700bb5ba3c092f511075d479d82ecb10fa5fe Co-authored-by: Peter Collins <[email protected]>
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Feb 4, 2021
New commits in xamarin/maccore: * xamarin/maccore@de616ca53e [mlaunch] Fix dependencies for Xcode 12.5 beta 1 (xamarin#2387) * xamarin/maccore@e93375583c [Actions] Fix rebase trigger. * xamarin/maccore@0dfeb85ff6 [CI][VSTS] Add information when the external tool fails. (xamarin#2377) * xamarin/maccore@87e165fdbb Remove Vincent as a code owner 😞 (xamarin#2368) * xamarin/maccore@55a700bb5b [build] Add /restore to Xamarin.Analysis build (xamarin#2366) * xamarin/maccore@2d9f8a9685 Bump to xamarin/xamarin-analysis@95245313 (xamarin#2362) Diff: https://github.com/xamarin/maccore/compare/428964bf32f06862eb4209129c6fb5b882c3b9be..de616ca53e22ebea66216374a15b8caf2ca77e3c
spouliot
added a commit
that referenced
this pull request
Feb 6, 2021
This version of Xcode requires macOS 11.0 or later. New commits in xamarin/maccore: * xamarin/maccore@de616ca53e [mlaunch] Fix dependencies for Xcode 12.5 beta 1 (#2387) * xamarin/maccore@e93375583c [Actions] Fix rebase trigger. * xamarin/maccore@0dfeb85ff6 [CI][VSTS] Add information when the external tool fails. (#2377) * xamarin/maccore@87e165fdbb Remove Vincent as a code owner 😞 (#2368) * xamarin/maccore@55a700bb5b [build] Add /restore to Xamarin.Analysis build (#2366) * xamarin/maccore@2d9f8a9685 Bump to xamarin/xamarin-analysis@95245313 (#2362) Diff: https://github.com/xamarin/maccore/compare/428964bf32f06862eb4209129c6fb5b882c3b9be..de616ca53e22ebea66216374a15b8caf2ca77e3c * Bump system mono to the latest available 2020-02 package. (#10402) This makes xamarin-macios build on Apple Silicon, and also seems to get an updated csc that fixes a problem with nullability warnings/errors. * [tests] Fix mmp-regression build ``` 10:59:46.5383210 Making all in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/mmp-regression 10:59:46.5392610 TargetFrameworkFallbackSearchPaths=/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Mono.framework/External/xbuild-frameworks MSBuildExtensionsPathFallbackPathsOverride=/Users/builder/azdo/_work/1/s/xamarin-macios/_mac-build/Library/Frameworks/Mono.framework/External/xbuild make all 10:59:46.6208220 /Applications/Xcode_12.5.0-beta.app/Contents/Developer/usr/bin/make clean 10:59:46.6956100 /Applications/Xcode_12.5.0-beta.app/Contents/Developer/usr/bin/make build 10:59:46.7422460 GEN dylib/libTest.dylib 10:59:46.8094820 ld: library not found for -lSystem 10:59:46.8097590 clang: error: linker command failed with exit code 1 (use -v to see invocation) 10:59:46.8110310 make[2]: *** [dylib/libTest.dylib] Error 1 10:59:46.8112570 make[1]: *** [run] Error 2 10:59:47.0030120 Process make exited with 2 ``` This happens on BigSur as it does not find the default location anymore... * [tests] Do not test GKLeaderboardViewController on BigSur The issue is the OS version, not the Xcode version. Update check to skip that test on macOS 11+ * [tests] Fix MSBuild tests / integration The test cannot work on BigSur since while you can `dlopen` the library you can open `fopen` it as a file (and can't embed it for the test). ``` 12:31:23.9407820 CSC : error CS1566: Error reading resource 'libz.dylib' -- 'Could not find file "/usr/lib/libz.dylib"' [/Users/builder/azdo/_work/1/s/xamarin-macios/tests/msbuild/Xamarin.MacDev.Tests/bin/Debug/net472/tmp-test-dir/msbuild-tests201/XM45Binding.csproj] 12:31:23.9407900 Done Building Project "/Users/builder/azdo/_work/1/s/xamarin-macios/tests/msbuild/Xamarin.MacDev.Tests/bin/Debug/net472/tmp-test-dir/msbuild-tests201/XM45Binding.csproj" (default targets) -- FAILED. ``` * [tests] Fix MTouch tests failures * `nm` changed it's output and test was updated * `clang` linking has a much higher limit for it's command-line length At least it does not seem to be OS specific since both 10.15 and 11.0 returns the same maximum ``` $ getconf ARG_MAX 1048576 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: WKWindowFeatures.h is not compiled (part of the framework umbrella)
and the
@interface WKWindowFeatures (WKPrivate)sounds like it shouldnot have been exposed (it's all fields starting with
_)