[runtime] Parameters passed on the stack use at least 8 bytes on x86-64. Fixes #58367. #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success |
spouliot
approved these changes
Aug 2, 2017
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Feb 17, 2021
New commits in xamarin/maccore: * xamarin/maccore@8fb2b410ae [Xamarin.Launcher] Use the right device to select the app architecture for watchOS apps. Fixes xamarin#2378. (xamarin#2399) Diff: https://github.com/xamarin/maccore/compare/c50173e637f7c10066f81dd8d130035f5672611a..8fb2b410ae12cd5a59352a023317a690a9f7b192
rolfbjarne
added a commit
that referenced
this pull request
Feb 18, 2021
#10655) New commits in xamarin/maccore: * xamarin/maccore@8fb2b410ae [Xamarin.Launcher] Use the right device to select the app architecture for watchOS apps. Fixes #2378. (#2399) Diff: https://github.com/xamarin/maccore/compare/c50173e637f7c10066f81dd8d130035f5672611a..8fb2b410ae12cd5a59352a023317a690a9f7b192
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Apr 21, 2021
New commits in xamarin/maccore: * xamarin/maccore@50605a5e7f [Xamarin.Hosting] Don't copy single-arch executable over a fat executable. (xamarin#2422) * xamarin/maccore@9a32b62193 [Xamarin.Hosting] Xcode seems to have changed some logic with regards to getting the primary instruments server. (xamarin#2421) * xamarin/maccore@3ae9018b64 [d16-9] [CI] remove login keychain password and xqa cert passwords (xamarin#2410) * xamarin/maccore@8fb2b410ae [Xamarin.Launcher] Use the right device to select the app architecture for watchOS apps. Fixes xamarin#2378. (xamarin#2399) Diff: https://github.com/xamarin/maccore/compare/c50173e637f7c10066f81dd8d130035f5672611a..50605a5e7fc46656d204ef938095c51e3c98ce99
rolfbjarne
added a commit
that referenced
this pull request
Apr 22, 2021
… the right architecture from fat apps. (#11259) * [mtouch] It seems watchOS simulators can automatically choose the right architecture from fat apps. So we can build a fat simulator app, and not depend on mlaunch copying in the specific architecture at launch time. A partial fix for xamarin/maccore#2411. * Bump maccore. New commits in xamarin/maccore: * xamarin/maccore@50605a5e7f [Xamarin.Hosting] Don't copy single-arch executable over a fat executable. (#2422) * xamarin/maccore@9a32b62193 [Xamarin.Hosting] Xcode seems to have changed some logic with regards to getting the primary instruments server. (#2421) * xamarin/maccore@3ae9018b64 [d16-9] [CI] remove login keychain password and xqa cert passwords (#2410) * xamarin/maccore@8fb2b410ae [Xamarin.Launcher] Use the right device to select the app architecture for watchOS apps. Fixes #2378. (#2399) Diff: https://github.com/xamarin/maccore/compare/c50173e637f7c10066f81dd8d130035f5672611a..50605a5e7fc46656d204ef938095c51e3c98ce99 * Bump maccore again. New commits in xamarin/maccore: * xamarin/maccore@1b3c9e5213 [Xamarin.Hosting] Fix build. (#2423) Diff: https://github.com/xamarin/maccore/compare/50605a5e7fc46656d204ef938095c51e3c98ce99..1b3c9e521318bfb90877e0bd964966c0724af73c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.xamarin.com/show_bug.cgi?id=58367