[gameplaykit] Added API bindings #2476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure |
rolfbjarne
requested changes
Aug 11, 2017
|
|
||
| [iOS(11,0), TV (11,0)] | ||
| [Export ("exportToURL:error:")] | ||
| bool ExportToURL (NSUrl url, [NullAllowed] NSError error); |
spouliot
approved these changes
Aug 11, 2017
There was a problem hiding this comment.
w'Rolf requested fix.
@migueldeicaza when merging can you add a comment on which beta(s) are covered by the PR ? thanks!
chamons
reviewed
Aug 11, 2017
| [Export ("setEntity:")] | ||
| void SetEntity (GKEntity entity); | ||
| } | ||
|
|
There was a problem hiding this comment.
Not to pick nits but a few extra new lines here?
chamons
approved these changes
Aug 11, 2017
dalexsoto
approved these changes
Aug 11, 2017
timrisi
reviewed
Aug 11, 2017
| @@ -70,6 +71,7 @@ | |||
| using NSBezierPath = global::XamCore.UIKit.UIBezierPath; | |||
| #endif | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Following Chris's nitpick, extra whitespace here, otherwise 👍
spouliot
suggested changes
Aug 15, 2017
There was a problem hiding this comment.
Some availability attributes (for the Mac) are also missing.
@migueldeicaza if you don't mind I'll fix those along with the URL casing
|
I do not mind. Machine at work is being reformatted. |
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Sep 28, 2017
Re-based from Miguel's PR xamarin#2476 including reviewers feedback. [1] xamarin#2476
|
#2798 rebase the PR (to |
spouliot
added a commit
that referenced
this pull request
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.