Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stellar-artalk): bump version, fix site name escape #452

Merged
merged 1 commit into from
May 9, 2024

Conversation

songtianlun
Copy link
Contributor

@songtianlun songtianlun commented Apr 28, 2024

修复以下问题:
1、低版本的 artalk js 无法对接高版本的 artalk 后端,升级配置文件中的版本;
2、模板中向 artalk 传递 site 名称使用了 <%= 转义会导致 artalk 无法对应站点,改用 <%- 解决。

例如我的博客名叫 Frytea's Blog ,但是在 artalk 看到请求的是类似 Frytea&#39;s Blog 导致 artalk 无法找到对应名字的站点,最终得到 404 错误。

Error: 未找到站点:`Frytea&#39;s Blog`,请在控制台创建站点

Fix the following issues:

  1. Older versions of artalk js cannot connect to newer versions of artalk backend, upgrade the version in the configuration file;
  2. Passing the site name to artalk in templates using <%= for escaping will cause artalk to not recognize the site correctly, use <%- instead.

For example, if my blog is named 'Frytea's Blog', but in artalk I see requests like 'Frytea's Blog', which causes artalk to be unable to find the corresponding site name, resulting in a 404 error.

Copy link

stackblitz bot commented Apr 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@xaoxuu xaoxuu merged commit 8004411 into xaoxuu:main May 9, 2024
@xaoxuu
Copy link
Owner

xaoxuu commented May 9, 2024

感谢大佬🫶

lliei0x pushed a commit to lliei0x-x/hexo-theme-stellar that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants