ocaml: harden against patchset checksum changing #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That md5 is the same as that sha256 on that file. What changed? |
|
The failure seems to be for the sha256 of a patch though, not the tarball. |
|
Can you add all the .patch files into this repo so that we wouldn't fail fetching them if github changes them in subtle ways? |
|
commit 5095d4fd3728a0b7783c24f4b45dbe663c9f4d7b |
Github doesn't include full indeces in patchsets by default allowing the contents of patches based on a commit to change. We can't recover the old version, but we can include the patch file in the repo so it's not affected by this behaviour. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
changed the title
lindig
approved these changes
Jun 5, 2023
jameshensmancitrix
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github did the old switcheroo and changes the context of a patch file. This is probably because github doesn't use full commit indeces by default in these file and it needed longer hashes to differenciate between commits.
This change is needed to pass the CI, it doesn't affect the tarball that's being packaged for releases