Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize cohorts for blockwise distribution of groups #299

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

dcherian
Copy link
Collaborator

Expected for some resampling workloads

In the future, we should automatically choose blockwise for the user.

| Change   | Before [bf936f52] <main>   | After [1f51a343] <cohorts-blockwise-opt>   |   Ratio | Benchmark (Parameter)                                      |
|----------|----------------------------|--------------------------------------------|---------|------------------------------------------------------------|
| -        | 1.86±0.06ms                | 651±10μs                                   |    0.35 | cohorts.PerfectBlockwiseResampling.time_find_group_cohorts |

Expected for some resampling workloads

In the future, we should choose blockwise for the user.
@dcherian dcherian enabled auto-merge (squash) December 27, 2023 05:00
@dcherian dcherian merged commit 20b662a into main Dec 27, 2023
19 checks passed
@dcherian dcherian deleted the cohorts-blockwise-opt branch December 27, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant