Manually fuse reindexing intermediates with blockwise reduction for cohorts. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
optimize-cohorts-graph
branch
from
fa65721
to
aeb1f9e
Compare
…ohorts. ``` | Change | Before [627bf2b] <main> | After [9d710529] <optimize-cohorts-graph> | Ratio | Benchmark (Parameter) | |----------|----------------------------|---------------------------------------------|---------|-------------------------------------------------| | - | 3.39±0.02ms | 2.98±0.01ms | 0.88 | cohorts.PerfectMonthly.time_graph_construct | | - | 20 | 17 | 0.85 | cohorts.PerfectMonthly.track_num_layers | | - | 23.0±0.07ms | 19.0±0.1ms | 0.83 | cohorts.ERA5Google.time_graph_construct | | - | 4878 | 3978 | 0.82 | cohorts.ERA5Google.track_num_tasks | | - | 179±0.8ms | 147±0.5ms | 0.82 | cohorts.OISST.time_graph_construct | | - | 159 | 128 | 0.81 | cohorts.ERA5Google.track_num_layers | | - | 936 | 762 | 0.81 | cohorts.PerfectMonthly.track_num_tasks | | - | 1221 | 978 | 0.8 | cohorts.OISST.track_num_layers | | - | 4929 | 3834 | 0.78 | cohorts.ERA5DayOfYear.track_num_tasks | | - | 351 | 274 | 0.78 | cohorts.NWMMidwest.track_num_layers | | - | 4562 | 3468 | 0.76 | cohorts.ERA5DayOfYear.track_num_tasks_optimized | | - | 164±1ms | 118±0.4ms | 0.72 | cohorts.ERA5DayOfYear.time_graph_construct | | - | 1100 | 735 | 0.67 | cohorts.ERA5DayOfYear.track_num_layers | | - | 3930 | 2605 | 0.66 | cohorts.NWMMidwest.track_num_tasks | | - | 3715 | 2409 | 0.65 | cohorts.NWMMidwest.track_num_tasks_optimized | | - | 28952 | 18798 | 0.65 | cohorts.OISST.track_num_tasks | | - | 27010 | 16858 | 0.62 | cohorts.OISST.track_num_tasks_optimized | ```
dcherian
force-pushed
the
optimize-cohorts-graph
branch
from
aeb1f9e
to
d5cb68c
Compare
dcherian
changed the title
dcherian
added a commit
that referenced
this pull request
May 2, 2024
* main: (64 commits) import `normalize_axis_index` from `numpy.lib` on `numpy>=2` (#364) Optimize `min_count` when `expected_groups` is not provided. (#236) Use threadpool for finding labels in chunk (#327) Manually fuse reindexing intermediates with blockwise reduction for cohorts. (#300) Bump codecov/codecov-action from 4.1.1 to 4.3.1 (#362) Add cubed notebook for hourly climatology example using "map-reduce" method (#356) Optimize bitmask finding for chunk size 1 and single chunk cases (#360) Edits to climatology doc (#361) Fix benchmarks (#358) Trim CI (#355) [pre-commit.ci] pre-commit autoupdate (#350) Initial minimal working Cubed example for "map-reduce" (#352) Bump codecov/codecov-action from 4.1.0 to 4.1.1 (#349) `method` heuristics: Avoid dot product as much as possible (#347) Fix nanlen with strings (#344) Fix direct quantile reduction (#343) Fix upstream-dev CI, silence warnings (#341) Bump codecov/codecov-action from 4.0.0 to 4.1.0 (#338) Fix direct reductions of Xarray objects (#339) Test with py3.12 (#336) ...
dcherian
added a commit
that referenced
this pull request
Jun 30, 2024
* main: Bump codecov/codecov-action from 4.3.1 to 4.4.1 (#366) Cubed blockwise (#357) Remove errant print statement import `normalize_axis_index` from `numpy.lib` on `numpy>=2` (#364) Optimize `min_count` when `expected_groups` is not provided. (#236) Use threadpool for finding labels in chunk (#327) Manually fuse reindexing intermediates with blockwise reduction for cohorts. (#300) Bump codecov/codecov-action from 4.1.1 to 4.3.1 (#362) Add cubed notebook for hourly climatology example using "map-reduce" method (#356) Optimize bitmask finding for chunk size 1 and single chunk cases (#360) Edits to climatology doc (#361) Fix benchmarks (#358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cubed is implementing its own code path, I think its OK to optimize to this degree.