Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cohorts: Use IntervalIndex to reduce search space. #304

Closed
wants to merge 5 commits into from
Closed

cohorts: Use IntervalIndex to reduce search space. #304

wants to merge 5 commits into from

Conversation

dcherian
Copy link
Collaborator

No description provided.

@dcherian dcherian mentioned this pull request Jan 1, 2024
Merged
@dcherian dcherian closed this in #306 Jan 2, 2024
@dcherian
Copy link
Collaborator Author

dcherian commented Jan 2, 2024

This was a great improvement for the county grouping but a regression for periodic time groupings where the bounding boxes are quite large and do not reduce the search space at all. In #306 I switched to using the bitmask to reduce the search space. This is even better for the county grouping and generally better for the periodic grouping. More optimizations are possible there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcherian