Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update backends tutorials intro #266

Merged
merged 25 commits into from
Sep 23, 2024
Merged

update backends tutorials intro #266

merged 25 commits into from
Sep 23, 2024

Conversation

JessicaS11
Copy link
Contributor

Navigating Xarray backends (engine="rioxarray") when using xr.open_dataset() can be confusing. One way to help clarify is by guiding the user through determining if the engine they need exists and is built-in, available from another library, or needs to be created. Here we introduce a flowchart to help guide that process.

@dcherian
Copy link
Contributor

Nice. Shall we stick this in the main docs instead? https://docs.xarray.dev/en/stable/user-guide/io.html

It strikes me that that page is also missing a nice intro ;)

@JessicaS11
Copy link
Contributor Author

Nice. Shall we stick this in the main docs instead? https://docs.xarray.dev/en/stable/user-guide/io.html

It strikes me that that page is also missing a nice intro ;)

Agreed... I can see some good arguments for this material (text and diagram) to go directly into the docs, and then this tutorial page just becomes a really short pointer to the docs page and the subsequent examples. Happy to move accordingly but wanted to keep refining the content while we decide.

@JessicaS11
Copy link
Contributor Author

@TomNicholas @scottyhq @negin513 @betolink Since this was ideated (thanks, Tom!) at our SciPy2024 tutorial planning meeting - any thoughts on where this diagram lives (docs versus tutorial, with a link from the other)?

@JessicaS11
Copy link
Contributor Author

JessicaS11 commented Jun 12, 2024

Can anyone help with the configuration options to get this building? To use the sphinxcontrib.mermaid extension, myst-parser is needed, but as soon as I added that I started getting an ".md extension already registered" error that I can't figure out how to resolve.

@scottyhq
Copy link
Contributor

Can anyone help with the configuration options to get this building? To use the sphinxcontrib.mermaid extension,

I'm hoping #270 (bumping sphinx versions) will just remedy this! I'll try to dig into it a bit more soon

@JessicaS11
Copy link
Contributor Author

I'm hoping #270 (bumping sphinx versions) will just remedy this! I'll try to dig into it a bit more soon

After some more thought and discussion with others, I'm going to move the diagram and some of this intro content to the docs as suggested by @dcherian. Then I'll revamp this PR to have a shorter intro that links to those pages.

@JessicaS11
Copy link
Contributor Author

See also (which will need to be merged before this PR): pydata/xarray#9175

Copy link

github-actions bot commented Jun 25, 2024

♻️ PR Preview daa22e6 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@JessicaS11 JessicaS11 changed the title update backends tutorials (and add a flowchart for engines) update backends tutorials intro Jun 25, 2024
@JessicaS11 JessicaS11 marked this pull request as ready for review September 9, 2024 20:12
@JessicaS11
Copy link
Contributor Author

@scottyhq @dcherian I think this is ready for review... I'd love confirmation that the list of built-in engines is right, because we've got different info in different places.

Copy link
Contributor

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I think the content flows better top to bottom and the flowchart in the main Xarray docs is great.

@scottyhq scottyhq merged commit 98b287b into main Sep 23, 2024
2 of 3 checks passed
@scottyhq scottyhq deleted the engine-flow branch September 23, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants