fix: support new datatree #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevang
commented
Oct 25, 2024
| # Rebuild multiindexes | ||
| dt = dt.set_index(dt.attrs.get("multiindexes", {})) | ||
| dt.dataset = dt.dataset.set_index(dt.attrs.get("multiindexes", {})) |
There was a problem hiding this comment.
This was the only thing actually broken on 2024.10.0, because they dropped some untested methods, to be re-implemented later.
|
LGTM, thank you for the quick update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xarray==2024.10.0 now has
DataTreeas public API, and the old prototype library has been archived.The modifications here drop support for the archived version and ensure everything works on the new version that's available in xarray. Only downside is we have to bump the lower bound on xarray support all the way up to present.