Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove obsolete modifier #2

Merged
merged 1 commit into from
Nov 4, 2021
Merged

fix: remove obsolete modifier #2

merged 1 commit into from
Nov 4, 2021

Conversation

0xAplki
Copy link
Contributor

@0xAplki 0xAplki commented Nov 2, 2021

Description of Changes

Removed obsolete modifier

Link to Audit Issue

How To Test

npm run testhalo or docker-compose then npm run testhalo

Developer Checklist:

  • I have followed the guidelines in our Contributing document
  • This PR has a corresponding JIRA ticket
  • My branch conforms with our naming convention i.e. feature/HDF-XXX-description
  • I have written new tests for your core changes, as applicable
  • I have successfully ran tests locally
  • I have formatted my code using format document in VSCode

Reviewers Checklist:

  • Code is readable and understandable; any unclear parts have explanations
  • UI/UX changes match the corresponding figma/other design resources, if applicable
  • I have successfully ran tests locally

tracyarciaga
tracyarciaga approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@tracyarciaga tracyarciaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buyback test passed

@schystz schystz self-requested a review November 4, 2021 11:39
@0xAplki 0xAplki merged commit 8c566d6 into post-audit/merge-to-develop Nov 4, 2021
@0xAplki 0xAplki deleted the post-audit/issue-3-remove-obsolete branch November 4, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyarciaga tracyarciaga tracyarciaga approved these changes

@schystz schystz schystz approved these changes

@bitcoinbrisbane bitcoinbrisbane Awaiting requested review from bitcoinbrisbane

@chris247474 chris247474 Awaiting requested review from chris247474

@mystbrent mystbrent Awaiting requested review from mystbrent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xAplki @schystz @tracyarciaga