Fix for SLR Scraper Error Fixes #1779 & #1815 #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Head request to check to ensure the image link was good didn't handle error. I have now added a switch that if it error out because of E.G DNS Resolution error it doesn't crash XBVR. Needs more testing has the conditions to cause the error are difficult to reproduce
|
As the one having the crash I would be happy to test a build but I don't see a way to get a test build. |
|
@pops64 I'm not 100% sure this fixed it because the crash seems to still be on the HEAD, see #1779 (comment) |
|
Log ... It should now at least tell you why and it shouldn't crash it should just do nothing in regards to the image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Head method to check to ensure the image link was good for SLR scrapes didn't handle errors. I have now added a switch that if it errors out because of E.G DNS Resolution error it doesn't crash XBVR and should print to the log the error. Complies and SLR scrapers run with out error.
Also moved the body close for the appCover Head method to outside the if statement to ensure
Body.Close()is always done per Go Docs