Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSTree] Fix missing codec for media playlist #1328

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Jul 17, 2023

Description

A kind of regression,
i remember now that when i had done the big parsers rework i had intentionally removed the codec property set here to try investigate on this weird parser implementation but i also forgot to readd it

to full fix this require a big rework of HLS parser to act like the other parsers
and maybe there is also the possibility to get rid of prepareRepresentation and other things around this...
this requires some study and time, one of many pending todo's (now add to roadmap)

Motivation and context

fix #1327

How has this been tested?

http://devimages.apple.com/iphone/samples/bipbop/gear1/prog_index.m3u8

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v21 Omega labels Jul 17, 2023
@glennguy glennguy merged commit 6974e00 into xbmc:Omega Jul 17, 2023
9 checks passed
@CastagnaIT CastagnaIT deleted the fix_hls_media_manifest branch July 17, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputstream.adaptive: UpdateStream: Unhandled video codec
2 participants