Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix cleanups #1345

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Small fix cleanups #1345

merged 2 commits into from
Aug 1, 2023

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Jul 31, 2023

Description

For the commit relative to EXT-X-DISCONTINUITY i found following HLS manifest
manifest_1690801308_child-video.txt (only video stream)
that set discontinuity tag on the top of all segments, playin this currently print Segment at position 0 not found error that its better change it

now it is not clear to me why has been added on top of all segments, fwik discontinuity should have at least one segment, so i changed error to debug logging

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v21 Omega labels Jul 31, 2023
@CastagnaIT CastagnaIT requested a review from glennguy July 31, 2023 11:43
@glennguy glennguy merged commit 593884f into xbmc:Omega Aug 1, 2023
9 checks passed
@CastagnaIT CastagnaIT deleted the minor_cleanup branch August 1, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants