Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings in contexpr #1360

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

joseluismarti
Copy link
Contributor

@joseluismarti joseluismarti commented Aug 21, 2023

Description

Small fix, I've seen it when compiling:

/home/user/inputstream.adaptive/src/utils/Utils.h:41:32: 
warning: ISO C++11 does not allow conversion from string literal to 'char *const' [-Wwritable-strings]
constexpr char* NAME_UNKNOWN = "unk"; // Kodi codec name for unknown codec
...

Since C++11 the string literal is const char*

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

Copy link
Collaborator

@CastagnaIT CastagnaIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you i havent found time to do it

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v21 Omega labels Aug 21, 2023
@CastagnaIT CastagnaIT merged commit 0b09c4a into xbmc:Omega Aug 23, 2023
9 checks passed
@joseluismarti joseluismarti deleted the constexpr-string branch August 23, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants