Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Leia] License Renewal for Youtube movies #588

Closed
wants to merge 3 commits into from

Conversation

MisterD81
Copy link
Contributor

@MisterD81 MisterD81 commented Jan 9, 2021

At least purchased movies in Youtube addon stopped working. Always after 5 minutes we can see in the logs that there is no decryption key. Surprisingly I was only able to get this license behavior only on Windows and Linux ARM. On Linux x64 the license renewal was not required.
See the corresponding bug in YT addon: anxdpanic/plugin.video.youtube#35

I figured out with EME logger of Chrome that the CDM is sending periodically a session message to renew the license.
IAS is not doing that at the moment which results in the behavior that playback always stops after 5 minutes. I found in the code the commented-out parts for the license renewal and activated them. The additional adjustments were required to ensure that the thread is stopped correctly. Otherwise Kodi crashes when the playback is finished or is stopped.

We can argue about the sleep duration, but I could not observe a high CPU increase or high delay when playback stopped with the 100ms.

Corresponding Matrix PR: #589

Ensure that Timer stops before CDM Adapter stops
@glennguy
Copy link
Contributor

Hi @MisterD81 we're branching to Kodi N very shortly and now on 19.1 stable - Leia branch is unlikely to get any more releases at this stage unless there's a critical bug

@MisterD81
Copy link
Contributor Author

Hi @glennguy ,
understood. Too bad that the PR was already there before Matrix release.
I close the request knowing that for example LibreElec RPi 2/3 users must build ISA on there own if they want to watch purchased YT movies with Kodi.

@MisterD81 MisterD81 closed this May 16, 2021
@MisterD81 MisterD81 deleted the License_Renewal_Leia branch May 16, 2021 12:50
@matthuisman
Copy link
Contributor

LibreELEC / CoreELEC could always patch their own builds of IA if they wanted
OSMC for example adds their own patches specific for his OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants