Tileserver: handle timezone-aware request parameters #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before trying to remove the timezone from a label, check that the relevant dimension is actually a datetime64. Addresses #807.
Codecov ReportBase: 92.86% // Head: 92.86% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 92.86% 92.86% -0.01%
==========================================
Files 410 410
Lines 32605 32610 +5
==========================================
+ Hits 30279 30283 +4
- Misses 2326 2327 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Note, test coverage dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #807.
With this PR, the xcube tileserver now handles timezone-aware timestamps in requests by converting them to timezone-naive timestamps before passing them to numpy. This avoids the warning
and, in future, the numpy error which will replace the warning.
Checklist:
docs/source/*CHANGES.md