Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with geotiff access from protected s3 bucket #864

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Fixed issue with geotiff access from protected s3 bucket #864

merged 5 commits into from
Jun 29, 2023

Conversation

TejasMorbagal
Copy link
Contributor

@TejasMorbagal TejasMorbagal commented Jun 29, 2023 •
edited
Loading

[Description of PR]

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@TejasMorbagal TejasMorbagal self-assigned this Jun 29, 2023
thomasstorm
thomasstorm approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please consider my comment.

xcube/core/store/fs/impl/dataset.py Outdated Show resolved Hide resolved
TonioF
TonioF requested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@TonioF TonioF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments (all small stuff).

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
AliceBalfanz
AliceBalfanz approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve under the condition, that Tonios comments are addressed :)

TejasMorbagal and others added 3 commits June 29, 2023 14:42
@TejasMorbagal TejasMorbagal linked an issue Jun 29, 2023 that may be closed by this pull request
Access Denied when requesting a geoTiff from protected s3 bucket #863
Closed
pont-us
pont-us approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@pont-us pont-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please fix the typo I found in the changelog :)

CHANGES.md Outdated Show resolved Hide resolved
@TejasMorbagal @pont-us
Update CHANGES.md
4a910aa 
Co-authored-by: Pontus Lurcock <[email protected]>
@TejasMorbagal TejasMorbagal merged commit 2be26a5 into master Jun 29, 2023
1 check passed
@TejasMorbagal TejasMorbagal deleted the TejasMorbagal-863-fix-geotiff-acess-to-private-s3 branch June 29, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonioF TonioF TonioF requested changes

@thomasstorm thomasstorm thomasstorm approved these changes

@pont-us pont-us pont-us approved these changes

@AliceBalfanz AliceBalfanz AliceBalfanz approved these changes

Assignees

@TejasMorbagal TejasMorbagal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access Denied when requesting a geoTiff from protected s3 bucket
5 participants
@TejasMorbagal @thomasstorm @TonioF @pont-us @AliceBalfanz