feat: implement support for delayed stack loading

xdebug · Mar 1, 2022 · 3f7ac61 · 3f7ac61
1 parent c6588ba
commit 3f7ac61
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,9 +4,13 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.25.0]
+
+- Implement delayed stack loading with startFrame and levels argument to StackTrace Request
+
 ## [1.24.3]
 
-- Fox for broken property traversal #755
+- Fix for broken property traversal #755
 
 ## [1.24.2]
 

diff --git a/src/phpDebug.ts b/src/phpDebug.ts
@@ -219,6 +219,7 @@ class PhpDebugSession extends vscode.DebugSession {
                 },
             ],
             supportTerminateDebuggee: true,
+            supportsDelayedStackTraceLoading: false,
         }
         this.sendResponse(response)
     }
@@ -741,7 +742,7 @@ class PhpDebugSession extends vscode.DebugSession {
             if (!connection) {
                 throw new Error('Unknown thread ID')
             }
-            const { stack } = await connection.sendStackGetCommand()
+            let { stack } = await connection.sendStackGetCommand()
             // First delete the old stack trace info ???
             // this._stackFrames.clear();
             // this._properties.clear();
@@ -781,7 +782,16 @@ class PhpDebugSession extends vscode.DebugSession {
                 this._errorStackFrames.set(id, status)
                 response.body = { stackFrames: [{ id, name, source, line, column: 1 }] }
             } else {
+                const totalFrames = stack.length
+                if (args.levels !== undefined && args.levels > 0) {
+                    stack = stack.filter(
+                        stackFrame =>
+                            stackFrame.level >= (args.startFrame ?? 0) &&
+                            stackFrame.level < (args.startFrame ?? 0) + args.levels!
+                    )
+                }
                 response.body = {
+                    totalFrames,
                     stackFrames: stack.map((stackFrame): VSCodeDebugProtocol.StackFrame => {
                         let source: VSCodeDebugProtocol.Source
                         let line = stackFrame.line