Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter extended property children by tag name #752

Merged
merged 1 commit into from
Feb 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).

## [1.24.1]

- Fix for extended root property #751

## [1.24.0]

- F10/F11 start debugging with stop on entry.
Expand Down
8 changes: 4 additions & 4 deletions src/xdebugConnection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ export class Property extends BaseProperty {
}
this.context = context
if (this.hasChildren) {
this.children = Array.from(propertyNode.childNodes).map(
this.children = Array.from((<Element>propertyNode).getElementsByTagName('property')).map(
(propertyNode: Element) => new Property(propertyNode, context)
)
}
Expand Down Expand Up @@ -644,9 +644,9 @@ export class PropertyGetResponse extends Response {
*/
constructor(document: XMLDocument, context: Context) {
super(document, context.stackFrame.connection)
this.children = Array.from(document.documentElement.firstChild!.childNodes).map(
(propertyNode: Element) => new Property(propertyNode, context)
)
this.children = Array.from(
(<Element>document.documentElement.firstChild!).getElementsByTagName('property')
).map((propertyNode: Element) => new Property(propertyNode, context))
}
}

Expand Down