[Base] Added Listing directories and filtering filenames by regex #2140
Conversation
Gliniak
force-pushed
the
ListDirectories&FilterFileNameByRegex
branch
from
c7f82ed
to
c4b6651
Compare
Gliniak
force-pushed
the
ListDirectories&FilterFileNameByRegex
branch
from
c4b6651
to
2ff4ff6
Compare
| @@ -123,6 +124,9 @@ struct FileInfo { | |||
| }; | |||
| bool GetInfo(const std::filesystem::path& path, FileInfo* out_info); | |||
| std::vector<FileInfo> ListFiles(const std::filesystem::path& path); | |||
| std::vector<FileInfo> ListDirectories(const std::filesystem::path& path); | |||
There was a problem hiding this comment.
Did the files where these functions are called accidentally slip under the radar of git add?
There was a problem hiding this comment.
No, these will be used in the future and in different PRs.
It will simplify loading patches and simplify loading profile directories in the future
There was a problem hiding this comment.
This may end up being removed as dead code at some point between the merging of this pull request and when the patches/profile changes arrive, or it may just deteriorate as nothing tests this code in practice, I think it'd be safer to submit these functions alongside the first use of them.
There was a problem hiding this comment.
I agree with that, but it's quite annoying if that change would appear in many PRs.
Maybe instead it would be better to add note about future usage?
Especially when we consider how long resolving all quirks in bigger PRs might take
No description provided.