Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1639465 [wpt PR 23706] - Ensure that <object>/<embed> navigation …
…bypasses Service Workers., a=testonly Automatic update from web-platform-tests Ensure that <object>/<embed> navigation bypasses Service Workers. Step 13 of https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm should exclude `embed` and `object` requests from Service Workers. Our implementation handles this correctly for the initial request, but failed to bypass the Service Worker for subsequent navigations. This patch adds a destination check to `ServiceWorkerMainResourceLoaderInterceptor::ShouldCreateForNavigation`, and ensures that the `destination` for a given request is set early enough in the lifecycle to ensure that the check succeeds. See also whatwg/fetch#948. Change-Id: I21a1d37da438e1d0f185696f2b3b4058bc3911fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209456 Reviewed-by: Matt Falkenhagen <[email protected]> Reviewed-by: Tsuyoshi Horo <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/master@{#773781} -- wpt-commits: 51e3a46a45c3a3ff3c934246d6de70fa3e63c7e9 wpt-pr: 23706 Differential Revision: https://phabricator.services.mozilla.com/D78336
- Loading branch information