Prevent caching dev versions of static files

[luboskmetko]

Because of the expire settings in .htaccess dev version of static files like main.css, app.bundle.js are cached for long time. This can result in cached files being used by browser instead of the updated files which can be quite confusing.

@jakub300 @JakubSzajna any ideas how to solve this while keeping expires settings for the build version?

[luboskmetko]

Per @marcinkrzeminski suggestion the following update to revisionPath function should solve this:

...
return sprintf(
  '%s/%s%s%s',
  get_template_directory_uri(),
  \Chisel\Settings::DIST_PATH,
  trim( $asset, '/' ),
  '?' . time()
);
...

If that's ok, I would submit PR.

[jakub300]

Is it working OK with browsersync css reloading? Also query string in production may somehow impact cdn caching. Wt., 8.01.2019, 12:38: Lubos Kmetko <[email protected]> napisał(a):

…

Per @marcinkrzeminski <https://github.com/marcinkrzeminski> suggestion the following update to revisionPath function should solve this: ... return sprintf( '%s/%s%s%s', get_template_directory_uri(), \Chisel\Settings::DIST_PATH, trim( $asset, '/' ), '?' . time() ); ... If that's ok, I would submit PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#409 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlSfTCBCCzKs5YgitpudSo_oWWzayztks5vBINPgaJpZM4Z1JY-> .

[luboskmetko]

@jakub300 seems to work ok with browsersync. Also it would be only used in dev mode so only here. Revisioning of production files would work like now.