Small PHP adjustments in Chisel methods #415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubSzajna
force-pushed
the
adjustments
branch
from
3f88ab3
to
93bf288
Compare
JakubSzajna
force-pushed
the
adjustments
branch
from
93bf288
to
0de6a71
Compare
|
I've also changed JS |
JakubSzajna
force-pushed
the
adjustments
branch
from
0de6a71
to
c6d400d
Compare
|
thanks @JakubSzajna @jakub300 @marcinkrzeminski could you please review this so we can merge it? |
luboskmetko
reviewed
Feb 18, 2019
| for (let i = 0; i < args.length; i += 1) { | ||
| el = args[i]; | ||
| let modifiers; | ||
| if(args[0] instanceof Array) { |
There was a problem hiding this comment.
@JakubSzajna just a missing space after if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey :)
As I was recently working with Chisel on a bigger project I've noticed two small adjustments I would add to the code.
The "default value" adjustments could be simplified to
return $value ?? $default_value;but our x5view does not use php7 by default yet and this would fail on the preview.