Skip to content

Commit

Permalink
Update: README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
xfl03 committed Jan 10, 2023
1 parent 0b23151 commit b426f38
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ public class JarRemapper {
public JarRemapper() {
int minecraftMajorVersion = VersionUtil.getMinecraftMajorVersion();
Map<String, String> mapping = new HashMap<>();
if (minecraftMajorVersion <= 16) {
if (minecraftMajorVersion <= 17) {
mapping.put("net/minecraftforge/fml/loading/moddiscovery/AbstractJarFileModLocator", "net/minecraftforge/fml/loading/moddiscovery/AbstractJarFileLocator");
}
if (minecraftMajorVersion <= 16) {
mapping.put("me/xfl03/morecrashinfo/fml/ModLocator.scanModsLegacy()Ljava/util/List;", "scanMods");
}
if (minecraftMajorVersion == 13) {
Expand Down
15 changes: 11 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,19 @@ Error Info:
```

## Compatibility
- Minecraft 1.13+ with Forge
- Java 8+
- Minecraft 1.13.2~1.16.5 & 1.18~1.19.3 with Forge
- Java 8~19

### Tested Environment
- Minecraft 1.16.5, Forge 36.2.39 and Java 8
- Minecraft 1.19.3, Forge 44.1.2 and Java 17

| Minecraft | Forge | Java |
|:---------:|:--------:|:----:|
| 1.19.3 | 44.1.2 | 17 |
| 1.18.2 | 40.2.0 | 17 |
| 1.16.5 | 36.2.39 | 8 |
| 1.15.2 | 31.2.57 | 8 |
| 1.14.4 | 28.2.26 | 8 |
| 1.13.2 | 25.0.223 | 8 |

## Develop
This mod implemented a powerful ASM-based remapping and custom jar detection feature to support cross-version Minecraft and Forge.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public static String getCallableMessages() {
for (CommonCallable callable : callables) {
sb.append("\t");
sb.append(callable.getLabel());
sb.append(":");
sb.append(": ");
sb.append(callable.get());
sb.append("\n");
}
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/me/xfl03/morecrashinfo/crash/MixinList.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ String innerCall() throws Exception {
return "Error getting mixin config: " + e;
}

if (configs == null || configs.isEmpty()) {
return "Not found";
}

List<List<String>> datas = new ArrayList<>();
datas.add(PrintHelper.createLine("Name", "Mixin Package", "Priority", "Required", "Targets"));
for (Object config : configs) {
Expand Down

0 comments on commit b426f38

Please sign in to comment.