Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Visual Studio solutions #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update for Visual Studio solutions #6

wants to merge 4 commits into from

Conversation

Zuzu-Typ
Copy link

@Zuzu-Typ Zuzu-Typ commented Aug 13, 2017

This pull request includes the following changes:

  • added support for building dynamic libraries (DLLs)
  • added Debug-NoHTTP configuration (+ a DLL version of every configuration)
  • added include directories and additional library paths (for ogg and opus)
  • added libogg.props (from vorbis)

Note#1: Merging this only makes sense, if xiph/ogg#29 is merged, because the solution searches for libogg.lib (instead of libogg_static.lib) in the respective *DLL subfolder if opus is built dynamically.
This can be changed of course, however it only makes sense to me this way

Note#2: This has not been tested with openssl, which I was unable to build successfully (it may or may not require additional include directories and / or library paths).

@rillian
Copy link
Contributor

rillian commented May 2, 2020

Parts of this, like the def file, should definitely be merged, but I'm not confident I can update the patch properly.

@mattgwwalker
Copy link

I would love to be able to compile x64 Windows DLLs for OpusFile. It seems Zuzu-Typ had done all the work to get the Visual Studio project working back in 2017, but this wasn't accepted.

It looks like GitHub's interface is saying that Zuzu-Typ's repository with the changes has been deleted (it's labelled an "unknown repository").

Is there a recommended way to compile OpusFile for Windows?

@rillian
Copy link
Contributor

rillian commented Jul 7, 2020

For other opus libraries, people have contributed cmake build configurations, which would be the preferred way to build it, except no one has done that for opusfile yet.

Note that our code integrating the Windows certificate store is currently broken; you'd need to find a work-around for that if you want to use the https support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants