-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Actions #1880
Add Github Actions #1880
Conversation
My initial feedback is that it would be good to have a transition period. To that point, we should keep the existing Travis builds where they do not conflict (e.g. pushing artifacts) with GitHub Actions. During such a transition we could contrast the CI systems and optimise our new configuration. Following are some considerations for a wholesale switch: With Travis, we have seen great benefit from We could skip building libaom and dav1d by using packages from Debian Sid and Debian Multimedia:
Considering the above, we might benefit from registering a Docker image with our build-deps preinstalled. |
First off, thanks for your review! I forgot to show you the effective results of this PR, you can find them here.
It seems fair. I will leave the old CI system as-is then. For what concerns pushing the artifacts, I had already implemented that feature through Github Actions. I was thinking to open a new PR for that, but perhaps I could merge that here. What do you think about it @barrbrain ?
Github Actions implements an independent cache system using an action called
I agree, we should be able to speed up a bit the entire process in this way.
We could add that later in my opinion, let's see how it works without |
cda429d
to
a11ce64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good baseline, let's iterate from here.
Let's follow that up in a new PR.
The |
Thanks for landing it!
I see, thanks for the explanation! I will try to fiddle with them |
As requested by @lu-zero, I've ported most of the CI tasks to the
Github Actions
system with the exception of thearm
tests that will remain onTravis
andAppVeyor
.The "Build and Coveralls" test is now done using
grcov
instead ofkcov
and can be run only on the nightly because of the -Z profile feature.The entire CI process takes approximately 25 minutes.
Thanks in advance for your review! :)