Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
vorbis_dynamic.sln
andvorbis_static.sln
tovorbis.sln
(instead it usesDebug
andRelease
for static andDebugDLL
andReleaseDLL
for dynamic, which is how it's done in opus)libogg.lib
instead oflibogg_static.lib
when building dynamically, so someone who built libogg dynamically doesn't have to waste time and disk space building libogg statically.Note#1: Merging this only makes sense if xiph/ogg#29 is merged too, because the new solution searches for libogg in e.g. DebugDLL
Note#2: The platform toolset of VS2015 is still v120, because I do not have Visual Studio 2015 on hand, so you might want to upgrade it to v140
I think this is everything I changed.