Changing _check_db_availability function in run.sh #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version of the _check_db_availability function is DB specific and assuming that dsmr-reader uses postgresql. This is true for most of the cases. Hovewer... The dsmr-reader is build on top of django which supports different database backends. This change is making _check_db_availability function universal and DB agnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of the _check_db_availability function is DB specific
and assuming that dsmr-reader uses postgresql. This is true for most of
the cases.
Hovewer...
The dsmr-reader is build on top of django which supports different database
backends. This change is making _check_db_availability function universal and
DB agnostic.
Related to #159