Skip to content

Commit

Permalink
Reenable FC Active State
Browse files Browse the repository at this point in the history
  • Loading branch information
Koenari committed Jul 2, 2023
1 parent cc73d56 commit 124efd3
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
10 changes: 5 additions & 5 deletions NetStone.Test/Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public class Tests
[SetUp]
public async Task Setup()
{
var gameData = PacksGameDataProvider.Load(new DirectoryInfo("../../../../lib/lodestone-data-exports/pack"));
var gameData =
PacksGameDataProvider.Load(new DirectoryInfo("../../../../lib/lodestone-data-exports/pack"));
this.lodestone = await LodestoneClient.GetClientAsync(gameData);
}

Expand Down Expand Up @@ -112,7 +113,7 @@ public async Task CheckFreeCompany()

//Focus
//todo: selector does not work
//Assert.AreEqual(ActiveTimes.Always, fc.ActiveState);
Assert.AreEqual("Always", fc.ActiveState);
Assert.AreEqual("Open", fc.Recruitment);

Assert.IsNotNull(fc.Focus);
Expand All @@ -123,9 +124,8 @@ public async Task CheckFreeCompany()

Assert.AreEqual("Leveling", fc.Focus.Leveling.Name);
Assert.IsTrue(fc.Focus.Leveling.IsEnabled);
//todo:Needs PR in css selectors
//Assert.AreEqual("https://img.finalfantasyxiv.com/lds/h/n/5Y0D3iH7ngHlRpv9-KJKalt3_o.png",
// fc.Focus.RolePlay.Icon?.AbsoluteUri);
Assert.AreEqual("https://img.finalfantasyxiv.com/lds/h/n/5Y0D3iH7ngHlRpv9-KJKalt3_o.png",
fc.Focus.Leveling.Icon?.AbsoluteUri);

Assert.AreEqual("Casual", fc.Focus.Casual.Name);
Assert.IsTrue(fc.Focus.Casual.IsEnabled);
Expand Down
8 changes: 4 additions & 4 deletions NetStone/Model/Parseables/FreeCompany/LodestoneFreeCompany.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using NetStone.Definitions;
using NetStone.Definitions.Model.FreeCompany;
using NetStone.Model.Parseables.FreeCompany.Members;
using NetStone.Search.FreeCompany;

namespace NetStone.Model.Parseables.FreeCompany;

Expand Down Expand Up @@ -96,13 +97,12 @@ public LodestoneFreeCompany(LodestoneClient client, HtmlNode rootNode, Definitio
/// </summary>
public int ActiveMemberCount => int.Parse(Parse(this.fcDefinition.ActiveMemberCount));

/*
/// <summary>
/// Activity status
/// </summary>
todo: selector does not work
public string ActiveState => Parse(this.fcDefinition.Activestate);
*/
//todo: selector does not work
public string ActiveState => Parse(this.fcDefinition.Activestate).Trim();


/// <summary>
/// Information about the estate
Expand Down
5 changes: 5 additions & 0 deletions NetStone/NetStone.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 124efd3

Please sign in to comment.