Windows support #28
Closed
Windows support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Includes <sys/time.h>, <sys/signal.h>, <sys/wait.h>
Note that uv_cond_* is only supported by node 0.9.3+, so Windows support is not yet possible with node 0.8.x -- but possibly in node 0.10.x. (cherry picked from commit c4f120cc7f0a49dbacc57548746137e262915a07) Conflicts: src/threads_a_gogo.cc
(cherry picked from commit 7a69a3707d7a38afdabddeb8190770f7eb9442da) Conflicts: src/threads_a_gogo.cc
Now compiles on Win32, although doesn't yet work properly. (cherry picked from commit 569ddd126560f9e4e11a580241d1757434cd238f) Conflicts: src/threads_a_gogo.cc
|
Does this support windows? |
|
Yes, but only for Node.js 0.9.3 and later. Please refer to https://github.com/audreyt/node-webworker-threads for a backward-compatible for that also offers a WebWorker API that can be installed on Windows easily. |
|
But can't install on Windows because the "os" setting in package.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #24 and #25, allowing threads_a_gogo compilation on Windows with node 0.9.3+.