Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up black in CI #376

Closed
wismill opened this issue Sep 20, 2023 · 2 comments · Fixed by #490
Closed

Hook up black in CI #376

wismill opened this issue Sep 20, 2023 · 2 comments · Fixed by #490
Labels
ci Continuous integration enhancement Indicates new feature requests

Comments

@wismill
Copy link
Member

wismill commented Sep 20, 2023 •
edited
Loading

From Peter in #364:

would be nice to hook up black in the CI [1] to ensure this doesn't accidentally get different formatting in the future.

[1] possibly via pre-commit.ci
@wismill wismill added enhancement Indicates new feature requests ci Continuous integration labels Sep 20, 2023
@whot
Copy link
Contributor

whot commented Sep 27, 2023

on this note, in flatpak/xdg-desktop-portal#1063 @WhyNotHugo pointed to http://pre-commit.ci as being a fast alternative to hand-rolling things (and a few other comments worth keeping in mind)

@wismill wismill mentioned this issue Sep 28, 2023
Merged
1 task
@wismill
Copy link
Member Author

wismill commented Sep 28, 2023

@whot I attempt a PR in #382 for local pre-commit.

@wismill wismill mentioned this issue Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous integration enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Add ruff formatting wismill/libxkbcommon
2 participants
@whot @wismill