Keysyms: improve generator #364
Conversation
Simplify evdev and XK_ substitution and improve alignment. Also, perform some additional XK_ substitutions in comments.
|
@wismill I wanted to ask, when you open a PR as draft do you still want reviews or should we wait until it's not a draft? |
@bluetech Good question! My take on draft PR is: “I inform you that I work on this topic; the code is sufficiently advanced to open an MR but not quite finished; you are welcome to review it but wait that I finish the draft if you do not have much time”. |
scripts/makeheader
Outdated
| re.VERBOSE, | ||
| ) | ||
| # Match remaining XK_ references | ||
| xorgproto_keysym_prefix_pattern = re.compile(r'\b(?P<prefix>\w*)XK_(?!KOREAN\b)') |
There was a problem hiding this comment.
got confused by this and had to check the various header files, would be nice to add something like:
# XK_KOREAN has ifdefs, ensure we handle those too
There was a problem hiding this comment.
It is confusing, indeed! This pattern is intended to match remaining keysyms references in comments, e.g. replace:
#define XKB_KEY_SunCompose 0x0000FF20 /* Same as XK_Multi_key */
with:
#define XKB_KEY_SunCompose 0x0000FF20 /* Same as XKB_KEY_Multi_key */
I updated the comment.
Simplify evdev and XK_ substitution and improve alignment. Also, perform some additional XK_ substitutions in comments.
Motivation: see MR in xorgproto