Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac os CI #346

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix mac os CI #346

merged 2 commits into from
Jun 26, 2023

Conversation

wismill
Copy link
Member

@wismill wismill commented Jun 23, 2023

No description provided.

@wismill wismill mentioned this pull request Jun 23, 2023
Closed
@wismill
Copy link
Member Author

wismill commented Jun 23, 2023

The issue seems to be with Doxygen 1.9.7, which changed the generated file names. It does not trigger in Linux because we use an older version.

@wismill wismill force-pushed the wip/fix-macOS-CI branch 6 times, most recently from 7975974 to 0255fb6 Compare June 23, 2023 15:08
@wismill wismill marked this pull request as ready for review June 23, 2023 15:25
@wismill
Copy link
Member Author

wismill commented Jun 23, 2023

There is a warning in the macOS CI:

Warning: Refusing to link macOS provided/shadowed software: bison
If you need to have bison first in your PATH, run:
  echo 'export PATH="/usr/local/opt/bison/bin:$PATH"' >> /Users/runner/.bash_profile

For compilers to find bison you may need to set:
  export LDFLAGS="-L/usr/local/opt/bison/lib"

I do not know if we should fix it.

@wismill wismill requested review from whot and bluetech June 23, 2023 15:28
@wismill wismill mentioned this pull request Jun 23, 2023
Open
whot
whot approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a reference to the doxygen bug in the commit message please? Saves us from having to dig up this PR in the future to check if it's still an issue and whatnot. Otherwise this LGTM, thanks!

@wismill
CI: Fix documentation generation for macOS
e7bdbb9 
- Force Doxygen version 1.9.6, because 1.9.7 breaks our doc cool URIs,
  i.e. our system that maintain stable doc pages via redirection.

  Associated issue in Doxygen:
  doxygen/doxygen#10146

- Install graphviz to build the .dot files.
@wismill wismill merged commit 2c86216 into xkbcommon:master Jun 26, 2023
4 checks passed
@wismill wismill deleted the wip/fix-macOS-CI branch June 26, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whot whot whot approved these changes

@bluetech bluetech Awaiting requested review from bluetech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wismill @whot